Skip to content

Feature/upup 458 ios sample update#2

Open
Kotliamba wants to merge 12 commits into
mainfrom
feature/UPUP-458-ios-sample-update
Open

Feature/upup 458 ios sample update#2
Kotliamba wants to merge 12 commits into
mainfrom
feature/UPUP-458-ios-sample-update

Conversation

@Kotliamba
Copy link
Copy Markdown

@Kotliamba Kotliamba commented Feb 9, 2023

https://ascnt.atlassian.net/browse/UPUP-458

Было сделано:

  1. Рефакторинг
  2. Обновление UI
  3. Баги со скроллингом

Не готово:
Форматирование поля в момент ввода

Make refactor
Fix bug with no scroll
Fix bug with no scroll-to-field
Fix bug no focus after submit
@Kotliamba Kotliamba requested a review from aartikov February 9, 2023 17:20
nextAnchor: nextAnchor
))
}
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Модификатор scrolledFocus не смогу проревьювить, давай, кто-нибудь из iOS-ребят посмотрит.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petrovichppp Паша, подключишься на ревью? Логику scrolledFocus взял почти целиком из SkinEpic

Comment thread sample/iosSample/iosSample/View/FormView.swift
Comment thread sample/iosSample/iosSample/View/TextFieldWithControl.swift Outdated
Comment thread sample/iosSample/iosSample/View/TextFieldWithControl.swift Outdated
Comment thread sample/iosSample/iosSample/View/TextFieldWithControl.swift Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants