GEOPY-2862: Inversion crash on tile mesh creation transferring data#406
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates octree mesh cell-convention handling to correctly permute attached child data when cell ordering is adjusted, and adds a test assertion related to that workflow.
Changes:
- Fix
ensure_cell_conventionso it reordersnp.ndarray-backed child values instead of skipping them. - Add an assertion in
test_mesh_visual_parameters_copycallingensure_cell_convention.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
simpeg_drivers/components/meshes.py |
Corrects the type check so per-cell numpy arrays on octree children are permuted with the updated cell ordering. |
tests/driver_test.py |
Adds a new assertion invoking ensure_cell_convention during an existing gravity driver test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/GA_4.8 #406 +/- ##
==================================================
+ Coverage 90.36% 90.42% +0.06%
==================================================
Files 110 110
Lines 6527 6527
Branches 826 826
==================================================
+ Hits 5898 5902 +4
+ Misses 416 413 -3
+ Partials 213 212 -1
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2862 - Inversion crash on tile mesh creation transferring data