Skip to content

GEOPY-2862: Inversion crash on tile mesh creation transferring data#406

Merged
domfournier merged 3 commits into
release/GA_4.8from
GEOPY-2862
May 12, 2026
Merged

GEOPY-2862: Inversion crash on tile mesh creation transferring data#406
domfournier merged 3 commits into
release/GA_4.8from
GEOPY-2862

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented May 12, 2026

GEOPY-2862 - Inversion crash on tile mesh creation transferring data

Copilot AI review requested due to automatic review settings May 12, 2026 16:35
@github-actions github-actions Bot changed the title GEOPY-2862 GEOPY-2862: Inversion crash on tile mesh creation transferring data May 12, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates octree mesh cell-convention handling to correctly permute attached child data when cell ordering is adjusted, and adds a test assertion related to that workflow.

Changes:

  • Fix ensure_cell_convention so it reorders np.ndarray-backed child values instead of skipping them.
  • Add an assertion in test_mesh_visual_parameters_copy calling ensure_cell_convention.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
simpeg_drivers/components/meshes.py Corrects the type check so per-cell numpy arrays on octree children are permuted with the updated cell ordering.
tests/driver_test.py Adds a new assertion invoking ensure_cell_convention during an existing gravity driver test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/driver_test.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.42%. Comparing base (ee55bf6) to head (52ef883).
⚠️ Report is 4 commits behind head on release/GA_4.8.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/GA_4.8     #406      +/-   ##
==================================================
+ Coverage           90.36%   90.42%   +0.06%     
==================================================
  Files                 110      110              
  Lines                6527     6527              
  Branches              826      826              
==================================================
+ Hits                 5898     5902       +4     
+ Misses                416      413       -3     
+ Partials              213      212       -1     
Files with missing lines Coverage Δ
simpeg_drivers/components/meshes.py 88.52% <100.00%> (+3.27%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit 8807eb5 into release/GA_4.8 May 12, 2026
11 of 12 checks passed
@domfournier domfournier deleted the GEOPY-2862 branch May 12, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants