fix: register file commands, fix endpoints, harden SSE & region validation#131
Merged
Conversation
- file list: GET /v1/files/list (not /v1/files) - file delete: POST /v1/files/delete with JSON body (not DELETE /v1/files?file_id=) - file_id is numeric, response has no 'deleted' field - response uses 'files' array, not 'data'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on #129, with endpoint fixes verified against real API.
file upload/list/deletecommands in registry (were implemented but inaccessible)file list: GET/v1/files/list(was/v1/files→ 404)file delete: POST/v1/files/deletewith JSON body (was DELETE/v1/files?file_id=→ 404)filesarray (notdata),file_idis numeric--region/MINIMAX_REGIONearly with clear error messageTest plan
bun test— 212 passbun run lint— cleanmmx file list— verified on both global and cn regionsmmx file delete --file-id <id>— verified on real APImmx --region mars— rejects with usage error