feat: add security data type in bridge metrics#8591
Closed
GeorgeGkas wants to merge 2 commits intomainfrom
Closed
Conversation
Contributor
|
As discussed we will close this in favor of this PR. Please reopen if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add
token_security_type_destinationas security classification of the destination token (securityData.type). Omitted if securityData is not present.References
Related: https://github.com/Consensys/segment-schema/pull/544
fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4420
Checklist
Note
Low Risk
Low risk: type-only analytics payload changes (new optional field) plus a changelog entry; no runtime logic changes.
Overview
Adds a new optional metrics property,
token_security_type_destination, to multiple Unified Swap/Bridge analytics event context payload types (includingInputSourceDestinationSwitched,Completed, andFailed) so clients can report the destination token’ssecurityData.typewhen available.Updates the
bridge-controllerchangelog to document the new analytics field.Reviewed by Cursor Bugbot for commit 5ec891e. Bugbot is set up for automated code reviews on this repo. Configure here.