feat: Add Across Gas Station support#8588
Open
pedronfigueiredo wants to merge 1 commit intomainfrom
Open
Conversation
7dc01ae to
72dc7b4
Compare
72dc7b4 to
45f1f77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gasFeeTokenwhen submitting Across source transactions that use source-token gas payment.Note
Medium Risk
Changes how Across quotes compute and represent source-network fees when native balance is low, and alters submission options by adding
gasFeeToken, which could affect transaction affordability and execution on EIP-7702 chains.Overview
Adds a shared
gas-stationhelper (and has Relay re-export it) to price gas in the source token viaTransactionController:getGasFeeTokenswhen the chain is eligible.Updates Across quoting to (1) switch
fees.sourceNetworkto gas-fee-token pricing when native balance is insufficient and gas station can price the source token, and (2) for max-amount requests, perform a second quote after subtracting the reserved gas amount from the source amount with safe fallbacks to the original quote.Updates Across submission to pass
gasFeeToken(source token address) to bothaddTransactionandaddTransactionBatchwhenfees.isSourceGasFeeTokenis set, with expanded tests covering the new behaviors.Reviewed by Cursor Bugbot for commit 45f1f77. Bugbot is set up for automated code reviews on this repo. Configure here.