Skip to content

feat: Expose KeyringController:exportSeedPhrase through messenger#8587

Open
GuillaumeRx wants to merge 3 commits intomainfrom
gr/keyring-controller-export-seed-phrase
Open

feat: Expose KeyringController:exportSeedPhrase through messenger#8587
GuillaumeRx wants to merge 3 commits intomainfrom
gr/keyring-controller-export-seed-phrase

Conversation

@GuillaumeRx
Copy link
Copy Markdown
Contributor

@GuillaumeRx GuillaumeRx commented Apr 27, 2026

Explanation

This adds KeyringController:exportSeedPhrase to MESSENGER_EXPOSED_METHODS and exports the type, as this was missed in #8391.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Adds a new messenger-exposed method for exporting the HD seed phrase, which is security-sensitive despite being mostly wiring/type-surface changes.

Overview
Exposes seed phrase export via the KeyringController messenger. This adds exportSeedPhrase to MESSENGER_EXPOSED_METHODS, introduces the KeyringController:exportSeedPhrase method action type, includes it in the KeyringControllerMethodActions union, and re-exports the new action type from src/index.ts.

Updates the keyring-controller changelog to announce the new messenger method.

Reviewed by Cursor Bugbot for commit 1a33bec. Bugbot is set up for automated code reviews on this repo. Configure here.

@GuillaumeRx GuillaumeRx force-pushed the gr/keyring-controller-export-seed-phrase branch from 4ed891d to 394112f Compare April 27, 2026 11:02
@GuillaumeRx GuillaumeRx marked this pull request as ready for review April 27, 2026 11:02
@GuillaumeRx GuillaumeRx requested review from a team as code owners April 27, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants