feat: Expose KeyringController:exportSeedPhrase through messenger#8587
Open
GuillaumeRx wants to merge 3 commits intomainfrom
Open
feat: Expose KeyringController:exportSeedPhrase through messenger#8587GuillaumeRx wants to merge 3 commits intomainfrom
KeyringController:exportSeedPhrase through messenger#8587GuillaumeRx wants to merge 3 commits intomainfrom
Conversation
4ed891d to
394112f
Compare
gantunesr
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This adds
KeyringController:exportSeedPhrasetoMESSENGER_EXPOSED_METHODSand exports the type, as this was missed in #8391.Checklist
Note
Medium Risk
Adds a new messenger-exposed method for exporting the HD seed phrase, which is security-sensitive despite being mostly wiring/type-surface changes.
Overview
Exposes seed phrase export via the KeyringController messenger. This adds
exportSeedPhrasetoMESSENGER_EXPOSED_METHODS, introduces theKeyringController:exportSeedPhrasemethod action type, includes it in theKeyringControllerMethodActionsunion, and re-exports the new action type fromsrc/index.ts.Updates the keyring-controller changelog to announce the new messenger method.
Reviewed by Cursor Bugbot for commit 1a33bec. Bugbot is set up for automated code reviews on this repo. Configure here.