You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying to grok the use cases for this, what are upsides and downsides? Anyway, we're going to be building out an IDE based upon FunSQL over at PlutoFunSQL.jl and putting together a roadmap here.
This PR simply adds supports for vectors, as in Lit(["a", "b", "c"]). It works fine in my experience (would be nice to finally merge it...).
Ideally though, I think all Julia values in literals (FunSQL.Lit(...)) should be converted to SQL parameters/placeholders, so that they use proper serialization from corresponding DB backends.
If I understand it correctly, one would be able to write things like WHERE bla='{2, 2}' as Where(Fun."="(Get.bla, [2, 2])). At the moment FunSQL will choke on anything of type Vector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could probably relax it to allow any vectors (eg numbers)?..