Skip to content

Fix tests#95

Merged
lrobion merged 8 commits into
MIT-LAE:mainfrom
lrobion:fix-tests
May 13, 2026
Merged

Fix tests#95
lrobion merged 8 commits into
MIT-LAE:mainfrom
lrobion:fix-tests

Conversation

@lrobion
Copy link
Copy Markdown
Contributor

@lrobion lrobion commented Mar 27, 2026

PR closes #94

  • Updates default YAML template to be consistent with deprecated entries
  • Fixes the YAML tests by updating test values and input.yaml to be consistent with deprecated entries
  • Reduces problem size for slow numerical solver tests (would some other opinions on if they still test what we want)
  • Hides failing tests (see Failing tests #94 for details) from ctest by putting into a hidden [.failing] group. They can still be run by calling the test binary explicitly (with tests/test_solver [failing] from the build directory). Did not use SKIP in Catch2 because ctest still reports those tests as failed for some reason...
  • Adds CI that builds APCEMM and runs tests for GCC 11.2 and 14.3. CI caches vcpkg binaries to avoid recompiling every time. This uses the GitHub Actions Cache which is cleared after 7 days of inactivity so the first CI action in a while will be slow (rebuild everything ~15mins) but actions that benefit from the cache take ~2mins.

@lrobion lrobion marked this pull request as draft March 27, 2026 22:18
@lrobion lrobion marked this pull request as ready for review May 13, 2026 18:15
@lrobion lrobion requested a review from ian-ross May 13, 2026 18:37
Copy link
Copy Markdown
Member

@ian-ross ian-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I sent you a message explaining what's going on with the cache stuff. Since you've got the CI actually working, I would consider this a grand success!

@lrobion lrobion merged commit adf714b into MIT-LAE:main May 13, 2026
@lrobion lrobion deleted the fix-tests branch May 13, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing tests

2 participants