Add tests for emoji detection#91
Conversation
- Added `testGetFullEmojiAtEndWithAllAvailableEmojis` to `StringUtilsTest.kt` to iterate over all emojis in assets and verify detection. - Fixed `StringUtils.mightBeEmoji` to include Mahjong Tiles and Symbols and Pictographs Extended-A blocks correctly (starting at 0x1F004 instead of 0x1F104) so `🀄` and `🃏` are recognized. - Removed todo comment in `isEmojiDetectsAllAvailableEmojis` since these emojis are now correctly identified. - Addressed `todo` about adding emoji detection tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `testGetFullEmojiAtEndWithAllAvailableEmojis` to `StringUtilsTest.kt` to iterate over all emojis in assets and verify detection. - Fixed `StringUtils.mightBeEmoji` to include Mahjong Tiles and Symbols and Pictographs Extended-A blocks correctly (starting at 0x1F004 instead of 0x1F104) so `🀄` and `🃏` are recognized. - Removed todo comment in `isEmojiDetectsAllAvailableEmojis` since these emojis are now correctly identified. - Addressed `todo` about adding emoji detection tests.
1 participant
Added tests for emoji detection as requested in issue #22.
Iterating through the emojis asset list ensures all emojis are processed correctly. Fixing
mightBeEmojiboundary condition ensures the test passes for specific emojis (e.g. Mahjong tile and Joker card) previously excluded.PR created automatically by Jules for task 7708604300233834285 started by @LeanBitLab