Fixup incorrect link elements for elfinder images in common_styles#92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
In the scope of #40 I've wrongly and accidentally removed the
falsegenerate link value for two elFinder image assets,causing the corresponding images to now be actively displayed below the elFinder instance on loading a page.
Note these are only visible in the 'standalone' version of the filemanager as in the popup they are hidden behind the actual instance.
AFTER - What is happening after this PR?
By restoring the
falsevalues, assets are once more cached by basset but not actively loaded, so that elFinder can still use them but they don't appear in the page.HOW
How did you achieve that, in technical terms?
??
Is it a breaking change or non-breaking change?
??
How can we test the before & after?
??