Skip to content

Update dependencies with vulnerabilities #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivansps merged 1 commit into from
May 11, 2026
+37 −12
Merged

Update dependencies with vulnerabilities #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 35 additions & 11 deletions Knossos.NET/Classes/KnUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ private static bool DecompressFileSharpCompress(string compressedFilePath, strin
//tar.gz
if (compressedFilePath!.ToLower().Contains(".tar") || compressedFilePath.ToLower().Contains(".gz"))
{
using (var reader = ReaderFactory.Open(fileStream))
using (var reader = ReaderFactory.OpenReader(fileStream))
{
while (reader.MoveToNextEntry())
{
Expand All @@ -1050,18 +1050,42 @@ private static bool DecompressFileSharpCompress(string compressedFilePath, strin
Log.Add(Log.LogSeverity.Warning, "KnUtils.DecompressFileSharpCompress()", $"Skipping potentially dangerous archive entry: {reader.Entry.Key}");
continue;
}
reader.WriteEntryToDirectory(destFolderPath, new ExtractionOptions() { ExtractFullPath = extractFullPath, Overwrite = true, WriteSymbolicLink = (source, target) =>

if (reader.Entry.Key == null)
{
continue;
}

var destinationPath = Path.Combine(destFolderPath, reader.Entry.Key);

// Detect SymbLink
if (reader.Entry.LinkTarget != null)
{
var resolvedTarget = Path.IsPathRooted(target)
? target
: Path.GetFullPath(Path.Combine(Path.GetDirectoryName(source)!, target));
if (!IsSubPath(destFolderPath, Path.GetRelativePath(destFolderPath, resolvedTarget)))
try
{
Log.Add(Log.LogSeverity.Warning, "KnUtils.DecompressFileSharpCompress()", $"Skipping symlink escaping destination: {source} -> {target}");
return;
var resolvedTarget = Path.IsPathRooted(reader.Entry.LinkTarget)
? reader.Entry.LinkTarget
: Path.GetFullPath(Path.Combine(Path.GetDirectoryName(destinationPath)!, reader.Entry.LinkTarget));
if (!IsSubPath(destFolderPath, Path.GetRelativePath(destFolderPath, resolvedTarget)))
{
Log.Add(Log.LogSeverity.Warning, "KnUtils.DecompressFileSharpCompress()", $"Skipping symlink escaping destination: {destinationPath} -> {reader.Entry.LinkTarget}");
continue;
}
File.CreateSymbolicLink(destinationPath, reader.Entry.LinkTarget);
}
File.CreateSymbolicLink(source, target);
}});
catch (Exception ex)
{
Log.Add(Log.LogSeverity.Error, "KnUtils.DecompressFileSharpCompress()", ex);
}
}
else
{
reader.WriteEntryToFile(destinationPath, new ExtractionOptions
{
ExtractFullPath = extractFullPath,
Overwrite = true
});
}
}
if (cancellationTokenSource!.IsCancellationRequested)
{
Expand All @@ -1073,7 +1097,7 @@ private static bool DecompressFileSharpCompress(string compressedFilePath, strin
else
{
//zip, 7z
using (var archive = ArchiveFactory.Open(fileStream))
using (var archive = ArchiveFactory.OpenArchive(fileStream))
{
var reader = archive.ExtractAllEntries();
while (reader.MoveToNextEntry())
Expand Down
3 changes: 2 additions & 1 deletion Knossos.NET/Knossos.NET.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@
<PackageReference Include="ini-parser-netstandard" Version="2.5.2" />
<PackageReference Include="Microsoft.Extensions.Http" Version="8.0.1" />
<PackageReference Include="ObservableCollections" Version="3.3.3" />
<PackageReference Include="SharpCompress" Version="0.39.0" />
<PackageReference Include="SharpCompress" Version="0.48.0" />
<PackageReference Include="Tmds.DBus.Protocol" Version="0.93.0" />
<PackageReference Include="WindowsShortcutFactory" Version="1.2.0" />
</ItemGroup>
<ItemGroup>
Expand Down