You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
JsonPoke isn't technically required, and while it is beneficial to use something that's specifically meant for JSON file writing, we don't really need it.
Modifications
Instead of utilizing JsonPoke, opt-for the built-in WriteLinesToFile. This did require a little hacky fix for proper indention, but it's not that hacky in my opinion. While WriteLinesToFile doesn't specifically support writing JSON, we aren't really writing much JSON in the first place.
I like it, especially because I think jsonpoke isn’t available for non-sdk projects. I’ll have to go over it in more detail and hopefully drew can take a look too since he set that stuff up initially.
Looks like this only generates the json? it cant modify an existing version file?
No, WriteLinesToFile would simply overwrite the file if it already exists. Which, if you're wanting an out-of-the-box version-file generator you don't really need to read existing JSON. It's more efficient to just overwrite anything already existing.
EDIT: Let me know if you agree with this PR or not, I'll resolve the conflicts.
Personally IMO, don't depend on jq or jsonPoke, the more complicated basic things are made the more time you spend maintaining it in the long-term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
JsonPoke isn't technically required, and while it is beneficial to use something that's specifically meant for JSON file writing, we don't really need it.
Modifications
WriteLinesToFile. This did require a little hacky fix for proper indention, but it's not that hacky in my opinion. WhileWriteLinesToFiledoesn't specifically support writing JSON, we aren't really writing much JSON in the first place.Results