perf: Optimize ModuleSystemHeatHarvester#168
Merged
Merged
Conversation
SystemHeat is actually pretty good here, and most of the overhead is in the stock module. The main thing we can optimize is to entirely disable the module when it is not active. Other than that I have gone through and changed stuff to make better use of the hooks that stock provides: * systemEfficency is used to replace GetHeatThrottle. This makes it so that it actually changes the converter rate like it is supposed to. Before the changes written to outputList and inputList were stomped over in PrepareRecipe. * We do UpdateFlux in PostProcess and reuse the TimeFactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SystemHeat is actually pretty good here, and most of the overhead is in the stock module. The main thing we can optimize is to entirely disable the module when it is not active.
Other than that I have gone through and changed stuff to make better use of the hooks that stock provides:
Most of performance optimizations for active drills are over in KSPModdingLibs/KSPCommunityFixes#374.
Together with that PR this fixes most of #167, but I think I still have some further things I want to try in a separate PR.