Add support for hot-reloading#166
Merged
Phantomical merged 1 commit intoMay 10, 2026
Merged
Conversation
Most of the changes here are just properly unregistering stuff when being destroyed, but there were a few explicit callbacks needed and it also uncovered a number of cases where HotReloadKSP wasn't quite handling things correctly. The explicit new changes to support reload are: * Load SystemHeatSettings when hot-loaded * Destroy the UI when SystemHeatUI is destroyed * We need to explicitly grab the prefab objects from the old assembly. Hot reloading still takes care of replacing any widgets within.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the changes here are just properly unregistering stuff when being destroyed, but there were a few explicit callbacks needed and it also uncovered a number of cases where HotReloadKSP wasn't quite handling things correctly.
The explicit new changes to support reload are:
Getting this to work requires HotReloadKSP v0.1.4