Fix Quaternion constructor argument order LoadDump method#3165
Merged
Conversation
The Unity Quaternion being constructed here takes arguments in the order of X, Y, Z, W. There was a bug here that provided them in the order of W, X, Y, Z, which will make the created Quaternion incorrect. Fixes KSP-KOS#3161
|
Just a reminder here |
Contributor
Author
Sadly I don't have the authority to merge stuff yet. Waiting on one of the official maintainers to accept the pull request or to be added to the maintainers group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unity Quaternion being constructed here takes arguments in the order of X, Y, Z, W. There was a bug here that provided them in the order of W, X, Y, Z, which will make the created Quaternion incorrect. Fixes #3161