Skip to content
This repository was archived by the owner on Apr 24, 2020. It is now read-only.

Throw on non-buffer, non-string messages#543

Open
platy wants to merge 2 commits into
JustinTulloss:masterfrom
platy:master
Open

Throw on non-buffer, non-string messages#543
platy wants to merge 2 commits into
JustinTulloss:masterfrom
platy:master

Conversation

@platy

@platy platy commented Jul 14, 2016

Copy link
Copy Markdown

rather than converting them to strings implicitly.

Fixes #542

@platy

platy commented Jul 14, 2016

Copy link
Copy Markdown
Author

It looks like the build it failed connecting to the mirror to download zmq

@rgbkrk

rgbkrk commented Aug 10, 2016

Copy link
Copy Markdown

If you rebase or make a new commit to trigger the build we can see it again (since you and I can't retrigger the build).

@platy

platy commented Aug 19, 2016

Copy link
Copy Markdown
Author

Made a new commit but it's still failing to download packages

@ronkorving

ronkorving commented Aug 22, 2016

Copy link
Copy Markdown
Collaborator

It looks like the tarball URLs have changed on http://download.zeromq.org/
We should make a separate PR to fix that.

update: I started #553 for that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants