Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+2
to
+3
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
|
|
||
|
|
||
| function lowerHomotopyReprKind( | ||
| varT::HomotopyRepr{R,K,T,L} |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| varT::HomotopyRepr{R,K,T,L} | |
| varT::HomotopyRepr{R, K, T, L}, |
| T <: AbstractStateType, | ||
| L <: AbstractPartialLegacyCompat, # FIXME use <:AbstractPartialTraits | ||
| } | ||
| typemeta = TypeMetadata(typeof(varT)) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| typemeta = TypeMetadata(typeof(varT)) | |
| return typemeta = TypeMetadata(typeof(varT)) |
| # StructUtils.lower(T::HomotopyDensityDFG) = lowerStateKind(T) | ||
| # StructUtils.lift(::Type{HomotopyDensityDFG}, s) = liftStateKind(s) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ## | ||
| ## ==================================================================================================== | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| - When lowered or for serde, this field is likely to hold Dict{Int, Vector{Float64}}. | ||
| """ | ||
| trailing_details::Dict{Int, Matrix{Float64}} = Dict( | ||
| 1 => Matrix{Float64}(I, manifold_dimension(getManifold(reprkind)), manifold_dimension(getManifold(reprkind))) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| 1 => Matrix{Float64}(I, manifold_dimension(getManifold(reprkind)), manifold_dimension(getManifold(reprkind))) | |
| 1 => Matrix{Float64}( | |
| I, | |
| manifold_dimension(getManifold(reprkind)), | |
| manifold_dimension(getManifold(reprkind)), | |
| ), |
Comment on lines
+171
to
+173
| structure::Dict{Int,Vector{Int}} = Dict( | ||
| 1 => collect(1:length(points)) | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| structure::Dict{Int,Vector{Int}} = Dict( | |
| 1 => collect(1:length(points)) | |
| ) | |
| structure::Dict{Int, Vector{Int}} = Dict(1 => collect(1:length(points))) |
| principal_coeffs = Float64[], | ||
| principal_elements = P[], # FIXME convert to Vector{Matrix{Float64}} instead, using affine_matrix | ||
| principal_details = Matrix{Float64}[], # TODO, upgrade to SMatrix, needs dimension | ||
| trailing_details = Dict{Int,Matrix{Float64}}(), # TODO, upgrade to sparsevec |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| trailing_details = Dict{Int,Matrix{Float64}}(), # TODO, upgrade to sparsevec | |
| trailing_details = Dict{Int, Matrix{Float64}}(), # TODO, upgrade to sparsevec |
| principal_details = Matrix{Float64}[], # TODO, upgrade to SMatrix, needs dimension | ||
| trailing_details = Dict{Int,Matrix{Float64}}(), # TODO, upgrade to sparsevec | ||
| mean_parents = Int[], | ||
| structure = Dict{Int,Vector{Int}}(), # TODO, upgrade to sparsevec of Vector{Int} |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| structure = Dict{Int,Vector{Int}}(), # TODO, upgrade to sparsevec of Vector{Int} | |
| structure = Dict{Int, Vector{Int}}(), # TODO, upgrade to sparsevec of Vector{Int} |
Comment on lines
+258
to
+260
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
+79
to
+98
| topology <: AbstractHomotopyTopology, | ||
| reprtype <: AbstractDensityBasis, | ||
| statetype <: Union{<:AbstractStateType, <:AbstractManifold}, # AbstractManifold used by AMP, but only StateType supports serde | ||
| L <: AbstractPartialLegacyCompat, # FIXME use <:AbstractPartialTraits | ||
| } | ||
| """ | ||
| Used for either DistributedFactorGraphs statetype or Manifolds.jl manifold type, depending on context. | ||
| Expect official support for serde only for DFG statetypes. Note, DFG statetypes are built on top of Manifolds.jl. | ||
| Use `getManifold(::HomotopyRepr)` to get the manifold type regardless of context. | ||
|
|
||
| Note, and explicit object `statekind` is needed for the Manifolds.jl only context, but note this field is not serialized | ||
| """ | ||
| statekind::statetype | ||
| """ | ||
| Future of partials is to use traits, so an abstract type is warranted. | ||
| Legacy is object of either Nothing, Tuple, or Vector{Int}, but something better is needed | ||
| """ | ||
| partial::L | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| topology <: AbstractHomotopyTopology, | |
| reprtype <: AbstractDensityBasis, | |
| statetype <: Union{<:AbstractStateType, <:AbstractManifold}, # AbstractManifold used by AMP, but only StateType supports serde | |
| L <: AbstractPartialLegacyCompat, # FIXME use <:AbstractPartialTraits | |
| } | |
| """ | |
| Used for either DistributedFactorGraphs statetype or Manifolds.jl manifold type, depending on context. | |
| Expect official support for serde only for DFG statetypes. Note, DFG statetypes are built on top of Manifolds.jl. | |
| Use `getManifold(::HomotopyRepr)` to get the manifold type regardless of context. | |
| Note, and explicit object `statekind` is needed for the Manifolds.jl only context, but note this field is not serialized | |
| """ | |
| statekind::statetype | |
| """ | |
| Future of partials is to use traits, so an abstract type is warranted. | |
| Legacy is object of either Nothing, Tuple, or Vector{Int}, but something better is needed | |
| """ | |
| partial::L | |
| end | |
| topology <: AbstractHomotopyTopology, | |
| reprtype <: AbstractDensityBasis, | |
| statetype <: Union{<:AbstractStateType, <:AbstractManifold}, # AbstractManifold used by AMP, but only StateType supports serde | |
| L <: AbstractPartialLegacyCompat, # FIXME use <:AbstractPartialTraits | |
| } | |
| """ | |
| Used for either DistributedFactorGraphs statetype or Manifolds.jl manifold type, depending on context. | |
| Expect official support for serde only for DFG statetypes. Note, DFG statetypes are built on top of Manifolds.jl. | |
| Use `getManifold(::HomotopyRepr)` to get the manifold type regardless of context. |
Comment on lines
+22
to
+23
| const AbstractPartialLegacyCompat = Union{<:DistributedFactorGraphs.AbstractPartialTraits, Nothing, Tuple, Vector{Int}} | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| const AbstractPartialLegacyCompat = Union{<:DistributedFactorGraphs.AbstractPartialTraits, Nothing, Tuple, Vector{Int}} | |
| const AbstractPartialLegacyCompat = | |
| Union{<:DistributedFactorGraphs.AbstractPartialTraits, Nothing, Tuple, Vector{Int}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See related PR in AMP: