Feature/itk volume conversions#394
Draft
mccle wants to merge 26 commits into
Draft
Conversation
Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com>
Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com>
Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com>
Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com>
Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com>
CPBridge
requested changes
Mar 19, 2026
| SimpleITK.Image: | ||
| Image constructed from the Volume. | ||
|
|
||
| """ |
Collaborator
There was a problem hiding this comment.
It would be nice to add some more information to the docstring to help users:
- SITK (itk) uses the same LPS convention as highdicom
- The returned volume is transposed to hide the difference in row major / column major orderings between the two formats transparent from the user
…cstrings; reformat strings
CPBridge
reviewed
May 7, 2026
| if array.min() >= f64.min and array.max() <= f64.max: | ||
| warnings.warn( | ||
| 'SimpleITK does not support float128 data.' | ||
| ' Safely recasting to float64.' |
Collaborator
There was a problem hiding this comment.
This is not really safe as it still involves a loss of precision (I think...)
Collaborator
There was a problem hiding this comment.
Also I think "casting" would be preferred to "recasting"
CPBridge
reviewed
May 7, 2026
CPBridge
reviewed
May 7, 2026
|
|
||
| else: | ||
| sitk_roundtrip = Volume.from_sitk(volume.to_sitk()) | ||
| assert sitk_roundtrip.dtype == volume.dtype |
Collaborator
There was a problem hiding this comment.
Wouldn't it be a good idea to test for equality of the arrays here? (except in cases where casting may lead to small differences)
CPBridge
reviewed
May 7, 2026
| 'zip_url,nifti_url', | ||
| [ | ||
| ( | ||
| 'https://github.com/neurolabusc/dcm_qa_mprage/raw/refs/heads/main/In/2_t1_mp2rage_sag_p3_32.zip', # noqa: E501 |
Collaborator
There was a problem hiding this comment.
I suggest that is might be neater to factor out "https://github.com/neurolabusc/dcm_qa_mprage/raw/refs/heads/main"
Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #387 for optional dependency importing.
Introduces 'to' and 'from' methods for the itk and SimpleITK libraries on the
highdicom.Volumeclass.