Use isinstance instead of type is for config#1028
Open
mdellweg wants to merge 1 commit intoIdentityPython:masterfrom
Open
Use isinstance instead of type is for config#1028mdellweg wants to merge 1 commit intoIdentityPython:masterfrom
mdellweg wants to merge 1 commit intoIdentityPython:masterfrom
Conversation
In Django you can use special settings drivers that may represent dicts as a subclass of pythons 'dict'. In this case leading to crash while parsing the metadata section of the config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Django you can use special settings drivers that may represent dicts as a subclass of pythons 'dict'. In this case leading to crash while parsing the metadata section of the config.
Description
The feature or problem addressed by this PR
What your changes do and why you chose this solution
It changes the check for an identical
dicttype to also match all subclasses.The change appears pretty straight forward to me, and allows pysaml2 to be used in combination with e.g. DynaConf.
I might need a pointer for a good strategy to test this.
Checklist