Alice #2
Open
AliceIoana wants to merge 7 commits into
Open
Conversation
vladutcornel
requested changes
Jul 21, 2022
vladutcornel
requested changes
Jul 26, 2022
Contributor
vladutcornel
left a comment
vladutcornel
left a comment
There was a problem hiding this comment.
Arată destul de bine.
Câteva chestii pe care le-am remarcat mai sus nu sunt rezolvate.
| image</span> | ||
| </a> | ||
| </li> | ||
| <li class="list"><a href="contact.html" class="menu-btn contact"><span class="material-symbols-outlined contact-icon"> |
Contributor
There was a problem hiding this comment.
Aranjează mai frumos elementele în cod
| context.moveTo(x1, y1); | ||
| context.lineTo(x2, y2); | ||
| context.stroke(); | ||
| context.closePath(); |
Contributor
There was a problem hiding this comment.
Interesantă ideea de a folosi canvas. Ai înțeles tot ce ai făcut aici?
Author
|
vscode-ul mi le pune asa, nu stiu de ce ca eu le-am mai rearanjat de cateva
ori, iar cu functia drawline,a m inteles ideea dar nu prea am inteles toti
pasii..mi s-a parut putin dificila functia sau nu m-am mai lovit eu de ceva
aseamanator.
În mie., 14 sept. 2022 la 22:39, A Cornel ***@***.***> a
scris:
… ***@***.**** commented on this pull request.
------------------------------
In src/about.html
<#2 (comment)>
:
> + <a href="#" class="logo-link"><img src="logo/Artă nouă și veche-logo.png" alt="logo Artă nouă și veche" class="logo-img"/></a>
+ <nav class="nav-bar small">
+ <ul class="line-icons">
+ <li class="list"><a href="index.html" class="menu-btn home"><span class="material-symbols-outlined home-icon">
+ home</span>
+ </a>
+ </li>
+ <li class="list"><a href="about.html" class="menu-btn about"><span class="material-symbols-outlined about-icon">
+ groups</span>
+ </a>
+ </li>
+ <li class="list"><a href="gallery.html" class="menu-btn gallery"><span class="material-symbols-outlined gallery-icon">
+ image</span>
+ </a>
+ </li>
+ <li class="list"><a href="contact.html" class="menu-btn contact"><span class="material-symbols-outlined contact-icon">
Aranjează mai frumos elementele în cod
------------------------------
In src/about.js
<#2 (comment)>
:
> + if (isDrawing) {
+ drawLine(context, x, y, e.offsetX, e.offsetY);
+ x = 0;
+ y = 0;
+ isDrawing = false;
+ }
+});
+
+function drawLine(context, x1, y1, x2, y2) {
+ context.beginPath();
+ context.strokeStyle = "black";
+ context.lineWidth = 1;
+ context.moveTo(x1, y1);
+ context.lineTo(x2, y2);
+ context.stroke();
+ context.closePath();
Interesantă ideea de a folosi canvas. Ai înțeles tot ce ai făcut aici?
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW3W33IUSWKNNCSCIRNUP73V6ISVXANCNFSM54IMU2FA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.