Skip to content

feat(Platform Notifications): add new service to the project#335

Open
AkosSz wants to merge 6 commits intoIBM:mainfrom
AkosSz:main
Open

feat(Platform Notifications): add new service to the project#335
AkosSz wants to merge 6 commits intoIBM:mainfrom
AkosSz:main

Conversation

@AkosSz
Copy link
Copy Markdown

@AkosSz AkosSz commented Apr 16, 2026

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Platform notifications integration added to the sdk.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Integration Test results

image

unit test results

image

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 16, 2026

CLA assistant check
All committers have signed the CLA.

AkosSz added 4 commits April 27, 2026 14:20
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
@AkosSz
Copy link
Copy Markdown
Author

AkosSz commented Apr 27, 2026

Do not merge yet

@pyrooka pyrooka changed the title feat(platform notifications) Add platform notifications to sdk feat(Platform Notifications): add new service to the project May 6, 2026
Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run the detect secrets tool through the project and update the .secrets.baseline file to make our CI happy. :) Also, please attach a screenshot of a clean examples test run too. Other than that, the changes are in a pretty good shape!

AkosSz added 2 commits May 7, 2026 09:42
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
@AkosSz
Copy link
Copy Markdown
Author

AkosSz commented May 7, 2026

example test runs:
image

were you thinking about adding the detect secrets as a pre-commit hook? 😅

@pyrooka
Copy link
Copy Markdown
Member

pyrooka commented May 7, 2026

were you thinking about adding the detect secrets as a pre-commit hook? 😅

Nope, just updating the .secrects.baseline file like you did in 50e76f3. Thanks for making these changes, we are good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants