Skip to content

Reworked move classification#93

Open
Salominius wants to merge 4 commits into
GuillaumeSD:mainfrom
Salominius:main
Open

Reworked move classification#93
Salominius wants to merge 4 commits into
GuillaumeSD:mainfrom
Salominius:main

Conversation

@Salominius
Copy link
Copy Markdown

  • restructured and simplified overall logic
    -> thereby improved some cases like perfect-detection that was firing too often before
  • added "miss"-classification
  • changed names of classifications (on second thought, I'm happy to change this back current names are preferred)

@GuillaumeSD
Copy link
Copy Markdown
Owner

Hi @Salominius , thanks for your PR, I have read it quickly, here are the things that needs to change before a real PR review can be done :

  • rollback classification names changes.
  • rollback miss classification. At this time we are unsure if we want to add "miss" classification in the project ever.

@Salominius
Copy link
Copy Markdown
Author

Okay, I've rolled back these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants