Skip to content

Sync UI language selection with user profile settings#14151

Open
Gpetrak wants to merge 8 commits intomasterfrom
ISSUE_14150
Open

Sync UI language selection with user profile settings#14151
Gpetrak wants to merge 8 commits intomasterfrom
ISSUE_14150

Conversation

@Gpetrak
Copy link
Copy Markdown
Member

@Gpetrak Gpetrak commented Apr 20, 2026

This PR was created according to this issue: #14150

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@Gpetrak Gpetrak added this to the 5.1.0 milestone Apr 20, 2026
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 20, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a user language preference system by introducing a new ProfileLanguageMiddleware, updating the profile form and admin interface, and adding a view to handle language selection. Feedback focuses on ensuring the user profile remains the source of truth for language settings, avoiding constant duplication, and persisting language changes to the database for authenticated users.

Comment thread geonode/base/middleware.py Outdated
Comment thread geonode/people/views.py Outdated
Comment thread geonode/people/views.py Outdated
@Gpetrak Gpetrak marked this pull request as ready for review April 21, 2026 07:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 80.53097% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.60%. Comparing base (94ca636) to head (0b73f6e).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14151      +/-   ##
==========================================
- Coverage   74.62%   74.60%   -0.03%     
==========================================
  Files         958      959       +1     
  Lines       57891    58282     +391     
  Branches     7889     7966      +77     
==========================================
+ Hits        43202    43482     +280     
- Misses      12927    13024      +97     
- Partials     1762     1776      +14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy removed this from the 5.1.0 milestone Apr 22, 2026
@Gpetrak Gpetrak linked an issue Apr 23, 2026 that may be closed by this pull request
Comment thread geonode/settings.py Outdated
@mattiagiupponi mattiagiupponi self-requested a review April 29, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync UI language selection with user profile settings

3 participants