Sync UI language selection with user profile settings#14151
Open
Sync UI language selection with user profile settings#14151
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a user language preference system by introducing a new ProfileLanguageMiddleware, updating the profile form and admin interface, and adding a view to handle language selection. Feedback focuses on ensuring the user profile remains the source of truth for language settings, avoiding constant duplication, and persisting language changes to the database for authenticated users.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14151 +/- ##
==========================================
- Coverage 74.62% 74.60% -0.03%
==========================================
Files 958 959 +1
Lines 57891 58282 +391
Branches 7889 7966 +77
==========================================
+ Hits 43202 43482 +280
- Misses 12927 13024 +97
- Partials 1762 1776 +14 🚀 New features to boost your workflow:
|
mattiagiupponi
requested changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created according to this issue: #14150
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.