Refactor CI/CD workflow for improved structure and clarity#1
Refactor CI/CD workflow for improved structure and clarity#1FullStackFlow-dev merged 1 commit intomainfrom
Conversation
Réorganisation du script ci-cd, du workflows GitHub action qui bloque le déploiement des nouvelles mises à jour, en production sur Vercel
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)✅ Unit Test PR creation complete.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b2571d4fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Note Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci-cd.yml:
- Around line 159-162: The deploy job is publishing a stale ./docs because the
report job uploads docs/latest-report.json as an artifact
(actions/upload-artifact@v4) but deploy never downloads it; add an
actions/download-artifact@v4 step in the deploy job (using name:
progress-report) before the GitHub Pages publish step so the generated
docs/latest-report.json is restored into the workspace (or into ./docs) and then
published; update the download step to place the artifact at the expected path
so the existing publish step can pick up the new report.
- Around line 120-157: The embedded Python here-doc under the GitHub Actions
step (the block starting with run: | and python3 << 'EOF') is not indented, so
YAML parses the script as outdented content and the workflow is invalid; fix by
indenting every line of the embedded script (all lines between the python3 <<
'EOF' and the closing EOF) so they are nested under the run: | block (i.e., add
consistent leading spaces so the here-doc block is a child of run: |), ensuring
the EOF markers remain aligned and the YAML parses; check the run step and
python3 << 'EOF' block after editing (the run: | step is the unique symbol to
locate).
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 50ee4abf-da1a-4560-a919-75fbb41865b6
📒 Files selected for processing (1)
.github/workflows/ci-cd.yml
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: progress-report | ||
| path: docs/latest-report.json |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
wc -l .github/workflows/ci-cd.ymlRepository: FullStackFlow-dev/Merph-dev-Portfolio
Length of output: 112
🏁 Script executed:
cat -n .github/workflows/ci-cd.yml | sed -n '150,200p'Repository: FullStackFlow-dev/Merph-dev-Portfolio
Length of output: 1036
Download the generated report artifact before publishing to GitHub Pages.
Lines 159-162 upload docs/latest-report.json as an artifact in the report job, but the deploy job (lines 179-185) never downloads it. Each GitHub Actions job runs in its own workspace. The fresh checkout in the deploy job at line 179 will publish the stale ./docs from the repository, not the newly generated report.
📦 Proposed fix
- uses: actions/checkout@v4
+
+ - uses: actions/download-artifact@v4
+ with:
+ name: progress-report
+ path: .
- uses: peaceiris/actions-gh-pages@v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./docs
publish_branch: gh-pages🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/ci-cd.yml around lines 159 - 162, The deploy job is
publishing a stale ./docs because the report job uploads docs/latest-report.json
as an artifact (actions/upload-artifact@v4) but deploy never downloads it; add
an actions/download-artifact@v4 step in the deploy job (using name:
progress-report) before the GitHub Pages publish step so the generated
docs/latest-report.json is restored into the workspace (or into ./docs) and then
published; update the download step to place the artifact at the expected path
so the existing publish step can pick up the new report.
✅ Confirmed as addressed by @FullStackFlow-dev
There was a problem hiding this comment.
- uses: actions/checkout@v4
-
- uses: actions/download-artifact@v4 -
with: -
name: progress-report -
path: . - uses: peaceiris/actions-gh-pages@v4 with: github_token: ${{ secrets.GITHUB_TOKEN }} publish_dir: ./docs publish_branch: gh-pages
There was a problem hiding this comment.
@FullStackFlow-dev, great — that's exactly the fix needed! With actions/download-artifact@v4 added before the GitHub Pages publish step, the freshly generated docs/latest-report.json will be restored into the workspace and correctly deployed instead of the stale version from the repository checkout. ✅
(_(
(-.-)
o_(")(")
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. An unexpected error occurred while generating fixes: Resource not accessible by integration - https://docs.github.com/rest/git/trees#create-a-tree |
|
✅ Created PR with unit tests: #2 |
1 participant
Réorganisation du script ci-cd, du workflows GitHub action qui bloque le déploiement des nouvelles mises à jour, en production sur Vercel
Summary by CodeRabbit