feat: Django-free structlog to OTel integration via otel extra#229
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 97.38% 97.39%
=======================================
Files 105 105
Lines 4595 4600 +5
=======================================
+ Hits 4475 4480 +5
Misses 120 120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add an `otel` extra carrying the dependencies of common.core.logging and common.core.otel, and import the Django, psycopg2 and Redis instrumentors lazily in setup_tracing — the only place they are used — so both modules import without Django installed. Enables non-Django services (first up: the MCP server) to reuse the structlog -> OTel processor chain. beep boop
Remove unnecessary docstring from test function.
matthewelwell
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New
otelextra so non-Django services can use the structlog → OTel processor chain.The Django/psycopg2/Redis instrumentors are imported lazily in
setup_tracing(), makingcommon.core.otelimportable without Django.How did you test this code?
Existing tests, plus built the wheel and verified
flagsmith-common[otel]importscommon.core.{logging,otel}in an isolated venv without Django.