feat: upgrade default review model to gpt-5.4 with high reasoning#65
Open
factory-arman wants to merge 11 commits intomainfrom
Open
feat: upgrade default review model to gpt-5.4 with high reasoning#65factory-arman wants to merge 11 commits intomainfrom
factory-arman wants to merge 11 commits intomainfrom
Conversation
Release 2026-02-12
Release 2026-02-12 v2
* fix: pre-compute review artifacts and deduplicate into shared module, remove security review from workflow (#34) * fix: pre-compute review artifacts and deduplicate into shared module, remove security review from workflow * test * fix: use review-candidates prompt and two-pass validator for automatic review flow * add gpt-5.2 default model * fix: default to gpt-5.2 with high reasoning and simplify model config * fix: include MCP tools in --enabled-tools for droid exec * add debugging * test with --list-tools * fix: resolve MCP server paths relative to repo root instead of sub-action directory * add model and reasoning effort * refactor: remove combine action and related prompt generation files * add --tag flags to droid exec calls * fix: reuse pre-computed review artifacts in validator step instead of redundant checkout * feat: update tracking comment after review completes (#35) * update tag * feat: update tracking comment after review completes in review sub-action Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> * fix: make tracking comment update non-blocking with continue-on-error Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> * fix: copy ~/.factory to temp dir before upload-artifact (tilde not expanded by Node.js glob) * fix: add include-hidden-files to upload-artifact and copy .factory via /Users/user --------- Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> * update to v3 (#36) * update to v3 * test dev * feat: update droid-review and droid workflows to streamline review process and enhance permissions * fix * update to v3 --------- Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Vn/release 2026 02 19 v2
* fix: forward review_model and reasoning_effort to validator step (#42) The v3 refactor removed the hardcoded gpt-5.2/high fallback from review-validator.ts but didn't add REVIEW_MODEL and REASONING_EFFORT to the Prepare validator step's env block in action.yml. This causes the validator pass to fall back to the Droid CLI's internal default model instead of using the user's configured review_model. * fix: pin upload-artifact to v4.6.2 SHA (#43) --------- Co-authored-by: Zahid Khawaja <zahidkhawaja@icloud.com>
Contributor
|
Droid finished @factory-arman's task —— View job Droid reviewed PR #65 — no actionable issues found. Summary: Clean configuration update changing the default review model from gpt-5.2/high to gpt-5.4/xhigh across action.yml, review/action.yml, and the corresponding test comment. |
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
factory-arman
force-pushed
the
arman/upgrade-review-model-gpt-5.4
branch
from
bc7432c to
e1a40b7
Compare
factory-arman
changed the title
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the default review model from
gpt-5.2(high reasoning) togpt-5.4(high reasoning) across the action configuration.Changes
action.yml: Updatedreview_modeldefault togpt-5.4and updated descriptionsreview/action.yml: Same defaults updatedtest/modes/tag/review-command.test.ts: Updated comment referencing the old defaults