Skip to content

Add FAF Tracker OAuth client#312

Open
Vind3ks wants to merge 3 commits intoFAForever:developfrom
Vind3ks:develop
Open

Add FAF Tracker OAuth client#312
Vind3ks wants to merge 3 commits intoFAForever:developfrom
Vind3ks:develop

Conversation

@Vind3ks
Copy link
Copy Markdown

@Vind3ks Vind3ks commented May 7, 2026

Adds an OAuth client for FAF Tracker

Website: https://faftracker.xyz
repo: https://github.com/Vind3ks/faftracker
Redirect URI: https://faftracker.xyz/api/auth/callback

Requested scopes:

  • openid
  • offline
  • public_profile
    - lobby

lobby is needed for live queue/lobby features

the actual oauth client secret isnt included in this PR

Summary by CodeRabbit

  • Chores
    • Added a new OAuth client "FAF Tracker" to Hydra configuration, supporting authorization code and refresh token grants with required scopes, redirect URI, and client metadata.
    • Added a local secret entry to support the FAF Tracker client for local deployments and testing.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a new "FAF Tracker" OAuth client entry to Ory Hydra Helm values and adds FAFTRACKER_SECRET: "banana" to the local Secret Helm template.

Changes

OAuth Client Registration

Layer / File(s) Summary
Local Secret Template
apps/ory-hydra/templates/local-secret.yaml
Adds FAFTRACKER_SECRET: "banana" to the stringData of the conditional Secret template.
OAuth Client Configuration
apps/ory-hydra/values.yaml
Adds FAF Tracker client entry with client id, secret reference (ory-hydra + FAFTRACKER_SECRET), grant types (authorization_code,refresh_token), scopes (openid,offline,public_profile), redirect URI (https://faftracker.xyz/api/auth/callback), logoUri, clientUri, and tokenEndpointAuthMethod: client_secret_post.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A little secret snug as "banana" bright,
FAF Tracker lands beneath Hydra's light,
Redirects set and scopes aligned just so,
Tokens will flow where auth winds blow,
Hopping on—deploy, and off we go!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add FAF Tracker OAuth client' directly and accurately summarizes the main change in the pull request, which adds a new OAuth client configuration entry for FAF Tracker.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sheikah45
Copy link
Copy Markdown
Member

Can you add a test secret like the others to the local-secret.yaml?

@Vind3ks
Copy link
Copy Markdown
Author

Vind3ks commented May 7, 2026

added FAFTRACKER_SECRET with the same dummy as other secret test secrets

@Sheikah45
Copy link
Copy Markdown
Member

Why did you add the lobby scope? That wasn't there when you said it in discord. That is only for playing the game.

@Vind3ks
Copy link
Copy Markdown
Author

Vind3ks commented May 8, 2026

as I said in the PR for live queue or lobby features that could be added, matchmaker_info/game_info
I mean if it's not something wanted for a website, I can just remove it and make limited to stats

@Sheikah45
Copy link
Copy Markdown
Member

Ah yeah missed that. There is more tied to the lobby scope so probably best to remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants