Add FAF Tracker OAuth client#312
Conversation
📝 WalkthroughWalkthroughAdds a new "FAF Tracker" OAuth client entry to Ory Hydra Helm values and adds ChangesOAuth Client Registration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Can you add a test secret like the others to the local-secret.yaml? |
|
added FAFTRACKER_SECRET with the same dummy as other secret test secrets |
|
Why did you add the lobby scope? That wasn't there when you said it in discord. That is only for playing the game. |
|
as I said in the PR for live queue or lobby features that could be added, matchmaker_info/game_info |
|
Ah yeah missed that. There is more tied to the lobby scope so probably best to remove it |
Adds an OAuth client for FAF Tracker
Website: https://faftracker.xyz
repo: https://github.com/Vind3ks/faftracker
Redirect URI: https://faftracker.xyz/api/auth/callback
Requested scopes:
- lobbylobby is needed for live queue/lobby featuresthe actual oauth client secret isnt included in this PR
Summary by CodeRabbit