Skip to content

Feat(ios): announce picker dismiss overlay to VoiceOver#24

Merged
arosiclair merged 1 commit into
Expensify:masterfrom
rushatgabhane:dismiss-a11y
Jun 8, 2026
Merged

Feat(ios): announce picker dismiss overlay to VoiceOver#24
arosiclair merged 1 commit into
Expensify:masterfrom
rushatgabhane:dismiss-a11y

Conversation

@rushatgabhane

@rushatgabhane rushatgabhane commented Jun 5, 2026

Copy link
Copy Markdown
Member

Fixes Expensify/App#77534

Tests

iOS native only - test on real device

  1. Update react-native-picker-select to point this fork
  2. Enable VoiceOver
  3. Go to Sign in page
  4. Swipe to the language dropdown button and double-tap to activate
  5. Swipe to the Done button
  6. Swipe once left to the "hidden" dismiss button
  7. Verify that Dismiss, button is announced

@rushatgabhane

rushatgabhane commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@QichenZhu will be reviewing this PR since a11y changes need real device (ideally)

@QichenZhu

Copy link
Copy Markdown

Looks good on iOS:

ios-hybrid.mp4
ios-hybrid-2.mp4

@QichenZhu

Copy link
Copy Markdown

@rushatgabhane we'll have another E/App PR, and I'll go through the checklist there, right?

@rushatgabhane

Copy link
Copy Markdown
Member Author

@rushatgabhane we'll have another E/App PR, and I'll go through the checklist there, right?

that is correct

@rushatgabhane

Copy link
Copy Markdown
Member Author

@arosiclair can you please final review #24
it is approved by @QichenZhu

@arosiclair arosiclair merged commit 69d750a into Expensify:master Jun 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[$250] [A11y] Screen Reader: Sign in: The button to dismiss the picker view is not announced

3 participants