Skip to content

Correctly spread touchableDoneProps #23

Closed
rushatgabhane wants to merge 1 commit into
Expensify:masterfrom
rushatgabhane:patch-1
Closed

Correctly spread touchableDoneProps #23
rushatgabhane wants to merge 1 commit into
Expensify:masterfrom
rushatgabhane:patch-1

Conversation

@rushatgabhane

@rushatgabhane rushatgabhane commented Jun 5, 2026

Copy link
Copy Markdown
Member

The prop was spread in the middle, so accessibilityLabel and accessibilityRole were not being overriden.

Fixes: Expensify/App#77534

@rushatgabhane rushatgabhane marked this pull request as ready for review June 5, 2026 21:55
@rushatgabhane

Copy link
Copy Markdown
Member Author

Hmm but it doesn't make sense

it("should use custom doneText as accessibilityLabel on Done button (iOS)", () => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[$250] [A11y] Screen Reader: Sign in: The button to dismiss the picker view is not announced

1 participant