Remove 'I can do almost anything, try me!' from Concierge welcome message#90384
Draft
MelvinBot wants to merge 1 commit into
Draft
Remove 'I can do almost anything, try me!' from Concierge welcome message#90384MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…sage Remove the tagline from the askConcierge translation string across all languages, keeping only the introductory sentence. Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index a98e7a05..5f24d492 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -850,7 +850,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Dein Bereich',
welcomeToRoom: (roomName: string) => `Willkommen in ${roomName}!`,
usePlusButton: (additionalText: string) => `Verwende die +‑Taste, um eine Ausgabe zu ${additionalText}.`,
- askConcierge: 'Dies ist dein Chat mit Concierge, deinem persönlichen KI-Agenten.',
+ askConcierge: 'Dies ist Ihr Chat mit Concierge, Ihrem persönlichen KI-Agenten.',
conciergeSupport: 'Dein persönlicher KI-Agent',
create: 'erstellen',
iouTypes: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 6acc0acf..188dd26a 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -795,7 +795,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Tu espacio',
welcomeToRoom: (roomName) => `¡Bienvenido a ${roomName}!`,
usePlusButton: (additionalText) => ` Usa el botón + para ${additionalText} un gasto`,
- askConcierge: 'Este es tu chat con Concierge, tu agente personal de IA.',
+ askConcierge: 'Este es tu chat con Concierge, tu agente de IA personal.',
conciergeSupport: 'Tu agente personal de IA',
create: 'crear',
iouTypes: {
@@ -1687,10 +1687,8 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Fondo del Modal',
},
nextStep: {
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas gastos.`;
@@ -1701,7 +1699,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_SUBMIT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> envíes los gastos.`;
@@ -1713,7 +1710,6 @@ const translations: TranslationDeepObject<typeof en> = {
},
[CONST.NEXT_STEP.MESSAGE_KEY.NO_FURTHER_ACTION]: (_actor, _actorType, _eta, _etaType) => `¡No se requiere ninguna acción adicional!`,
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_SUBMITTER_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas una cuenta bancaria.`;
@@ -1728,7 +1724,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? ` el ${eta} de cada mes` : ` ${eta}`;
}
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que tus gastos se envíen automáticamente${formattedETA}.`;
@@ -1739,7 +1734,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_FIX_ISSUES]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> soluciones ellos problemas.`;
@@ -1750,7 +1744,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_APPROVE]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> apruebes los gastos.`;
@@ -1761,7 +1754,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_EXPORT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> exportes este informe.`;
@@ -1772,7 +1764,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_PAY]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> pagues los gastos.`;
@@ -1783,7 +1774,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_POLICY_BANK_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> termines de configurar una cuenta bancaria de empresa.`;
@@ -1803,7 +1793,6 @@ const translations: TranslationDeepObject<typeof en> = {
[CONST.NEXT_STEP.MESSAGE_KEY.SUBMITTING_TO_SELF]: (_actor, _actorType, _eta, _etaType) =>
`¡Ups! Parece que estás enviando el informe a <strong>ti mismo</strong>. Aprobar tus propios informes está <strong>prohibido</strong> por tu espacio de trabajo. Por favor, envía este informe a otra persona o contacta a tu administrador para cambiar la persona a la que lo envías.`,
[CONST.NEXT_STEP.MESSAGE_KEY.REJECTED_REPORT]: (actor, actorType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Este informe fue rechazado. Esperando a que <strong>tú</strong> corrijas los problemas y lo vuelvas a enviar manualmente.`;
@@ -2458,7 +2447,6 @@ ${amount} para ${merchant} - ${date}`,
two: 'º',
few: 'º',
other: 'º',
- /* eslint-disable @typescript-eslint/naming-convention */
'1': 'Primero',
'2': 'Segundo',
'3': 'Tercero',
@@ -2469,7 +2457,6 @@ ${amount} para ${merchant} - ${date}`,
'8': 'Octavo',
'9': 'Noveno',
'10': 'Décimo',
- /* eslint-enable @typescript-eslint/naming-convention */
},
},
approverInMultipleWorkflows: 'Este miembro ya pertenece a otro flujo de aprobación. Cualquier actualización aquí se reflejará allí también.',
@@ -6931,7 +6918,6 @@ ${amount} para ${merchant} - ${date}`,
restrictedDescription: 'Sólo las personas en tu espacio de trabajo pueden encontrar esta sala',
privateDescription: 'Sólo las personas que están invitadas a esta sala pueden encontrarla',
publicDescription: 'Cualquier persona puede unirse a esta sala',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announceDescription: 'Cualquier persona puede unirse a esta sala',
createRoom: 'Crea una sala de chat',
roomAlreadyExistsError: 'Ya existe una sala con este nombre',
@@ -6951,7 +6937,6 @@ ${amount} para ${merchant} - ${date}`,
restricted: 'Espacio de trabajo',
private: 'Privada',
public: 'Público',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announce: 'Anuncio Público',
},
},
@@ -7266,7 +7251,6 @@ ${amount} para ${merchant} - ${date}`,
updatedDefaultTitle: (newDefaultTitle, oldDefaultTitle) => `cambió la fórmula personalizada del nombre del informe a "${newDefaultTitle}" (previamente "${oldDefaultTitle}")`,
updatedOwnership: (oldOwnerEmail, oldOwnerName, policyName) => `asumió la propiedad del espacio de trabajo ${policyName} de ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled) => `${enabled ? 'habilitó' : 'deshabilitó'} el envío programado`,
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount,
budgetFrequency,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 3c50a21f..4bdd0114 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -853,7 +853,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Votre espace',
welcomeToRoom: (roomName: string) => `Bienvenue dans ${roomName} !`,
usePlusButton: (additionalText: string) => `Utilisez le bouton + pour ${additionalText} une dépense.`,
- askConcierge: 'Ceci est votre chat avec Concierge, votre agent IA personnel.',
+ askConcierge: 'Voici votre conversation avec Concierge, votre assistant IA personnel.',
conciergeSupport: 'Votre agent IA personnel',
create: 'créer',
iouTypes: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 44122ac5..37550059 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -851,7 +851,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Il tuo spazio',
welcomeToRoom: (roomName: string) => `Benvenuto in ${roomName}!`,
usePlusButton: (additionalText: string) => `Usa il pulsante + per ${additionalText} una spesa.`,
- askConcierge: 'Questa è la tua chat con Concierge, il tuo agente IA personale.',
+ askConcierge: "Questa è la tua chat con Concierge, il tuo assistente personale basato sull'IA.",
conciergeSupport: 'Il tuo agente IA personale',
create: 'crea',
iouTypes: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 16ffbd27..69323e47 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -837,7 +837,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'あなたのスペース',
welcomeToRoom: (roomName: string) => `${roomName} へようこそ！`,
usePlusButton: (additionalText: string) => `+ ボタンを使って経費を${additionalText}します。`,
- askConcierge: 'こちらはあなた専属のAIエージェント、Conciergeとのチャットです。',
+ askConcierge: 'これは、お客様専用の AI エージェントである Concierge とのチャットです。',
conciergeSupport: 'あなた専用のAIエージェント',
create: '作成',
iouTypes: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 86a75f75..2b3218bf 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -849,7 +849,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Jouw ruimte',
welcomeToRoom: (roomName: string) => `Welkom bij ${roomName}!`,
usePlusButton: (additionalText: string) => `Gebruik de +-knop om een uitgave te ${additionalText}.`,
- askConcierge: 'Dit is je chat met Concierge, je persoonlijke AI-agent.',
+ askConcierge: 'Dit is je chat met Concierge, je persoonlijke AI-assistent.',
conciergeSupport: 'Jouw persoonlijke AI-agent',
create: 'maken',
iouTypes: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index e55a8b04..c41ef461 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -850,7 +850,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Twoja przestrzeń',
welcomeToRoom: (roomName: string) => `Witaj w ${roomName}!`,
usePlusButton: (additionalText: string) => `Użyj przycisku +, aby ${additionalText} wydatek.`,
- askConcierge: 'To Twój czat z Concierge, Twoim osobistym agentem AI.',
+ askConcierge: 'To jest twój czat z Concierge, twoim osobistym agentem AI.',
conciergeSupport: 'Twój osobisty agent AI',
create: 'utwórz',
iouTypes: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index b8e590b7..9adab4e9 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -825,7 +825,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: '你的空间',
welcomeToRoom: (roomName: string) => `欢迎来到 ${roomName}！`,
usePlusButton: (additionalText: string) => `使用 + 按钮来${additionalText}一笔费用。`,
- askConcierge: '这是您与 Concierge（您的个人 AI 代理）的聊天。',
+ askConcierge: '这是你与 Concierge（你的个人 AI 助手）的聊天。',
conciergeSupport: '您的专属AI助手',
create: '创建',
iouTypes: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Remove the "I can do almost anything, try me!" tagline from the Concierge welcome message across all 10 supported languages (en, de, es, fr, it, ja, nl, pl, pt-BR, zh-hans). The message now ends after "This is your chat with Concierge, your personal AI agent." Updated the corresponding unit test assertion as well.
Fixed Issues
$
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari