Always show Update credentials for Sage Intacct connections#90359
Draft
MelvinBot wants to merge 2 commits into
Draft
Always show Update credentials for Sage Intacct connections#90359MelvinBot wants to merge 2 commits into
MelvinBot wants to merge 2 commits into
Conversation
…w menu For Sage Intacct connections, always show the Update credentials option alongside Sync now, since Intacct uses rotatable Web Services credentials (company ID, user ID, password) rather than OAuth tokens. For all other integrations, the existing auth-error-only behavior is preserved unchanged. Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 112855a0..afe10a04 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -6188,7 +6188,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
connectPrompt: ({connectionName}: ConnectionNameParams) =>
`Sind Sie sicher, dass Sie ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName] ?? 'diese Buchhaltungsintegration'} verbinden möchten? Dadurch werden alle bestehenden Buchhaltungsverbindungen entfernt.`,
enterCredentials: 'Gib deine Anmeldedaten ein',
- updateCredentials: 'Update credentials',
+ updateCredentials: 'Anmeldedaten aktualisieren',
claimOffer: {
badgeText: 'Angebot verfügbar!',
xero: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 020cdbdb..85401907 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1687,10 +1687,8 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Fondo del Modal',
},
nextStep: {
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas gastos.`;
@@ -1701,7 +1699,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_SUBMIT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> envíes los gastos.`;
@@ -1713,7 +1710,6 @@ const translations: TranslationDeepObject<typeof en> = {
},
[CONST.NEXT_STEP.MESSAGE_KEY.NO_FURTHER_ACTION]: (_actor, _actorType, _eta, _etaType) => `¡No se requiere ninguna acción adicional!`,
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_SUBMITTER_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas una cuenta bancaria.`;
@@ -1728,7 +1724,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? ` el ${eta} de cada mes` : ` ${eta}`;
}
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que tus gastos se envíen automáticamente${formattedETA}.`;
@@ -1739,7 +1734,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_FIX_ISSUES]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> soluciones ellos problemas.`;
@@ -1750,7 +1744,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_APPROVE]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> apruebes los gastos.`;
@@ -1761,7 +1754,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_EXPORT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> exportes este informe.`;
@@ -1772,7 +1764,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_PAY]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> pagues los gastos.`;
@@ -1783,7 +1774,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_POLICY_BANK_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> termines de configurar una cuenta bancaria de empresa.`;
@@ -1803,7 +1793,6 @@ const translations: TranslationDeepObject<typeof en> = {
[CONST.NEXT_STEP.MESSAGE_KEY.SUBMITTING_TO_SELF]: (_actor, _actorType, _eta, _etaType) =>
`¡Ups! Parece que estás enviando el informe a <strong>ti mismo</strong>. Aprobar tus propios informes está <strong>prohibido</strong> por tu espacio de trabajo. Por favor, envía este informe a otra persona o contacta a tu administrador para cambiar la persona a la que lo envías.`,
[CONST.NEXT_STEP.MESSAGE_KEY.REJECTED_REPORT]: (actor, actorType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Este informe fue rechazado. Esperando a que <strong>tú</strong> corrijas los problemas y lo vuelvas a enviar manualmente.`;
@@ -2458,7 +2447,6 @@ ${amount} para ${merchant} - ${date}`,
two: 'º',
few: 'º',
other: 'º',
- /* eslint-disable @typescript-eslint/naming-convention */
'1': 'Primero',
'2': 'Segundo',
'3': 'Tercero',
@@ -2469,7 +2457,6 @@ ${amount} para ${merchant} - ${date}`,
'8': 'Octavo',
'9': 'Noveno',
'10': 'Décimo',
- /* eslint-enable @typescript-eslint/naming-convention */
},
},
approverInMultipleWorkflows: 'Este miembro ya pertenece a otro flujo de aprobación. Cualquier actualización aquí se reflejará allí también.',
@@ -6931,7 +6918,6 @@ ${amount} para ${merchant} - ${date}`,
restrictedDescription: 'Sólo las personas en tu espacio de trabajo pueden encontrar esta sala',
privateDescription: 'Sólo las personas que están invitadas a esta sala pueden encontrarla',
publicDescription: 'Cualquier persona puede unirse a esta sala',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announceDescription: 'Cualquier persona puede unirse a esta sala',
createRoom: 'Crea una sala de chat',
roomAlreadyExistsError: 'Ya existe una sala con este nombre',
@@ -6951,7 +6937,6 @@ ${amount} para ${merchant} - ${date}`,
restricted: 'Espacio de trabajo',
private: 'Privada',
public: 'Público',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announce: 'Anuncio Público',
},
},
@@ -7266,7 +7251,6 @@ ${amount} para ${merchant} - ${date}`,
updatedDefaultTitle: (newDefaultTitle, oldDefaultTitle) => `cambió la fórmula personalizada del nombre del informe a "${newDefaultTitle}" (previamente "${oldDefaultTitle}")`,
updatedOwnership: (oldOwnerEmail, oldOwnerName, policyName) => `asumió la propiedad del espacio de trabajo ${policyName} de ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled) => `${enabled ? 'habilitó' : 'deshabilitó'} el envío programado`,
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount,
budgetFrequency,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 68d35ba4..067e6a78 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -6209,7 +6209,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
connectPrompt: ({connectionName}: ConnectionNameParams) =>
`Voulez-vous vraiment connecter ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName] ?? 'cette intégration comptable'} ? Cette action supprimera toutes les connexions comptables existantes.`,
enterCredentials: 'Saisissez vos identifiants',
- updateCredentials: 'Update credentials',
+ updateCredentials: 'Mettre à jour les identifiants',
claimOffer: {
badgeText: 'Offre disponible !',
xero: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 2bee6799..83d9f4b0 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6178,7 +6178,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
connectPrompt: ({connectionName}: ConnectionNameParams) =>
`Sei sicuro di voler collegare ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName] ?? 'questa integrazione contabile'}? Questo rimuoverà tutte le connessioni contabili esistenti.`,
enterCredentials: 'Inserisci le tue credenziali',
- updateCredentials: 'Update credentials',
+ updateCredentials: 'Aggiorna credenziali',
claimOffer: {
badgeText: 'Offerta disponibile!',
xero: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 7d1faaf7..279f34af 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6107,7 +6107,7 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
connectPrompt: ({connectionName}: ConnectionNameParams) =>
`${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName] ?? 'この会計連携'} を接続してもよろしいですか？これにより、既存の会計連携はすべて削除されます。`,
enterCredentials: '認証情報を入力してください',
- updateCredentials: 'Update credentials',
+ updateCredentials: '認証情報を更新',
claimOffer: {
badgeText: 'オファーをご利用いただけます！',
xero: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index bbefe751..71635c9a 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6156,7 +6156,7 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
connectPrompt: ({connectionName}: ConnectionNameParams) =>
`Weet je zeker dat je ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName] ?? 'deze boekhoudkoppeling'} wilt koppelen? Hierdoor worden alle bestaande boekhoudkundige koppelingen verwijderd.`,
enterCredentials: 'Voer je inloggegevens in',
- updateCredentials: 'Update credentials',
+ updateCredentials: 'Inloggegevens bijwerken',
claimOffer: {
badgeText: 'Aanbieding beschikbaar!',
xero: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index bc9c344c..5218bd66 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6150,7 +6150,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
connectPrompt: ({connectionName}: ConnectionNameParams) =>
`Czy na pewno chcesz połączyć ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName] ?? 'ta integracja księgowa'}? Spowoduje to usunięcie wszystkich istniejących połączeń księgowych.`,
enterCredentials: 'Wprowadź swoje dane logowania',
- updateCredentials: 'Update credentials',
+ updateCredentials: 'Zaktualizuj dane logowania',
claimOffer: {
badgeText: 'Oferta dostępna!',
xero: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 435b147a..317b55c3 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6157,7 +6157,7 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
connectPrompt: ({connectionName}: ConnectionNameParams) =>
`Tem certeza de que deseja conectar ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName] ?? 'esta integração contábil'}? Isso removerá quaisquer conexões contábeis existentes.`,
enterCredentials: 'Insira suas credenciais',
- updateCredentials: 'Update credentials',
+ updateCredentials: 'Atualizar credenciais',
claimOffer: {
badgeText: 'Oferta disponível!',
xero: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 9e73f8f3..9cac95fc 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6004,7 +6004,7 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
connectPrompt: ({connectionName}: ConnectionNameParams) =>
`确定要连接 ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName] ?? '此会计集成'} 吗？这将删除所有现有的会计连接。`,
enterCredentials: '请输入您的凭证',
- updateCredentials: 'Update credentials',
+ updateCredentials: '更新凭证',
claimOffer: {
badgeText: '优惠可用！',
xero: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Guard on policyID truthiness instead of defaulting to '-1' Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
Contributor
Author
|
Fixed the failing ESLint check: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
For Sage Intacct connections, always show the "Update credentials" option in the accounting overflow menu alongside "Sync now". Unlike OAuth-based integrations, Sage Intacct uses rotatable Web Services credentials (company ID, user ID, password), so admins need to update them proactively without waiting for a sync failure.
Changes:
shouldShowEnterCredentialsto also be true when the connected integration is Sage IntacctstartIntegrationFlow(which would incorrectly land on the prerequisites/existing-connections page when there's no auth error)updateCredentialstranslation key to all locale filesFixed Issues
$ #90281
PROPOSAL: #90281 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
// TODO: The human co-author must fill out the offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari