[WIP] [Performance] Dismiss-first navigation for all remaining expense submission paths#90347
Draft
JakubKorytko wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Improve perceived performance of expense submission from
QAB/FABacross all IOU types (PAY,SPLIT,TRACK,SUBMIT/REQUEST) by adding dismiss-first navigation and deferred writes.The RHP now animates closed while navigating to the destination underneath, and API writes are deferred until after the transition completes.
Also adds full telemetry coverage (
startTracking,setFastPath,setPendingSubmitFollowUpAction) to skip-confirmation paths (scan,distance,split+receipt) that previously had none, enablingSubmitToDestinationVisiblespan measurement.Fixed Issues
$
PROPOSAL: N/A
Tests
Prerequisite: For an action to appear in the QAB, you need to perform it once via FAB first (e.g. create a manual PAY expense via FAB so that PAY appears as the QAB action).
Expected behavior for all tests below:
PAY (QAB - skip-confirmation)
TRACK (QAB - skip-confirmation)
TRACK (FAB - full flow with confirmation)
SUBMIT/REQUEST (QAB - skip-confirmation)
SPLIT (FAB - full flow with confirmation)
SPLIT + scan (skip-confirmation)
INVOICE (FAB - full flow with confirmation)
Scan skip-confirmation (SUBMIT/TRACK)
Offline tests
Same as tests.
QA Steps
Same as test.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari