feat(cli): show eval progress durations in ms#1187
Draft
Conversation
Deploying agentv with
|
| Latest commit: |
020c420
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f089c28.agentv.pages.dev |
| Branch Preview URL: | https://feat-1186-progress-durations.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
τ agent/totalmswhen both metrics are availabledurationMsandevalRun.durationMsthrough core progress events into the CLI progress displayCloses #1186.
Root Cause
The eval runner already computed both per-agent duration (
result.durationMs) and full eval duration (result.evalRun.durationMs), but the progress event shape and CLI formatter dropped those values before rendering the completed result line. Once surfaced, the raw numbers could still be misleading because provider-reported agent duration can exceed local wall-clock eval timing for mock or remote targets.Validation
bun test apps/cli/test/commands/eval/progress-display.test.tsbun test apps/cli/test/commands/eval/statistics-inconclusive.test.tsbun --filter @agentv/core typecheckbun --filter agentv typecheckgit pushpre-push hook passed: build, typecheck, lint, test, validate example evalsRed/Green UAT
Command used in both cases:
NO_COLOR=1 bun apps/cli/dist/cli.js eval examples/features/execution-metrics/evals/dataset.eval.yaml --target mock_metrics_agent --test-id simple-thresholds-pass --workers 1Before (
main):After (
feat/1186-progress-durations-ms):