Disha/subworkflow test#37
Open
Dishalodha wants to merge 13 commits intomainfrom
Open
Conversation
|
|
||
| stub: | ||
| def prefix = task.ext.prefix ?: "${meta.accession}" | ||
| def accession = meta.accession ?: meta.id ?: "stub" |
Collaborator
There was a problem hiding this comment.
I'm wondering if this value should not be passed as meta.id from somewhere else for the testing?
|
|
||
| output: | ||
| tuple val(meta), env(user), env(host), env(port), env(password), env(database), emit: connection_info | ||
| tuple val(meta), env('user'), env('host'), env('port'), env('password'), env('database'), emit: connection_info |
Collaborator
There was a problem hiding this comment.
I believe we have not discussed this, but would like to consider having a line length limit in Nextflow as we do in Python.
Collaborator
Author
There was a problem hiding this comment.
we should be able to correct this while correcting the linting
Comment on lines
-14
to
+15
| - ensembl-genomio:genome_metadata_prepare | ||
| - ensembl-genomio:schemas_json_validate | ||
| - metadata/genomesummary | ||
| - schema/json |
Collaborator
There was a problem hiding this comment.
Can you explain why this change was needed? Just to learn 🤓
Collaborator
Author
There was a problem hiding this comment.
Based on my search, in subworkflow we want to mention the nextflow modules used as components as 2 is only the minimum number but we could be using more.
Co-authored-by: Jorge Alvarez-Jarreta <jalvarez@ebi.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I have
PS: nf-linting still needs correction.