Per-kernel driver fixes round 3: kernel 6.14 green for all 8 drivers#50
Merged
Conversation
lwfinger/rtl8723bu upstream HEAD == the recipe's old SRCREV; there's nothing to bump and the cfg80211_ops.get_tx_power signature change in kernel 6.14 was breaking the build. Fork lwfinger/rtl8723bu to EmbeddedAndroid/rtl8723bu and add a guarded link_id parameter on the embeddedandroid branch.
morrownr/8814au upstream gated the cfg80211_ops radio_idx parameter on LINUX_VERSION_CODE >= 6.14, but radio_idx actually landed in kernel 6.17. Result was broken builds on 6.14-6.16. Fork to EmbeddedAndroid/8814au and split the guard: link_id at 6.14+, radio_idx at 6.17+.
The EmbeddedAndroid/rtl8723du embeddedandroid branch now carries guards for two more cfg80211_ops changes: - set_monitor_channel gained struct net_device * in kernel 6.13 - get_tx_power gained unsigned int link_id in kernel 6.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third pass of per-kernel-version maintenance. With this PR the (driver, kernel) compile matrix is fully green across rtl8192eu / rtl8723bu / rtl8723du / rtl8812au / rtl8814au / rtl8821au / rtl8821cu / rtl88x2bu against kernels 6.6, 6.12 and 6.14.
rtl8723du: bumped the EmbeddedAndroid/rtl8723du fork SRCREV to absorb two more cfg80211_ops signature changes:
rtl8723bu: switched from lwfinger/rtl8723bu to a new EmbeddedAndroid/rtl8723bu fork. lwfinger's HEAD == the recipe's existing SRCREV (no upstream activity), so the kernel 6.14 get_tx_power signature change had nowhere to land upstream. Fork carries the same link_id guard as rtl8723du.
rtl8814au: switched from morrownr/8814au to a new EmbeddedAndroid/8814au fork. Upstream had already added kernel guards for radio_idx in set_wiphy_params / set_tx_power / get_tx_power, but gated them on LINUX_VERSION_CODE >= 6.14 — radio_idx didn't actually land until kernel 6.17, so the build broke on 6.14, 6.15, 6.16. Fork splits the guards: link_id at 6.14+, radio_idx at 6.17+.
Native (driver, kernel) compile matrix at this PR's SRCREVs:
Three EmbeddedAndroid driver forks now exist alongside the existing rtl8723du fork: rtl8723bu, 8814au. All three carry their per-kernel fixes on an 'embeddedandroid' branch that starts from the respective upstream HEAD.