Modernize layer, add CI, fix recipe metadata#47
Merged
Conversation
…SION
Drop EOL series (dunfell, gatesgarth, mickledore) and claim
compatibility with kirkstone, scarthgap, styhead, walnascar,
whinlatter and wrynose. Anchor BBFILE_PATTERN to ^${LAYERDIR}/
so other layers can't be accidentally matched.
The recipe describes the RTL8192EU chipset, not RTL8192AU. This was likely a copy-paste artifact from when the recipe was first added.
…KSUM The SUMMARY/DESCRIPTION described RTL88x2BU (copy-paste from rtl88x2bu.bb when this recipe was added). Switch to the correct chipset name, declare DEPENDS on virtual/kernel explicitly, and drop the weak (?=) assignment for the license checksum so downstream overrides don't accidentally mask it.
Parse the layer against the kirkstone, scarthgap, styhead and walnascar poky branches on every push and PR, plus a fetch job that exercises every recipe's SRC_URI to catch upstream disappearances early. Also runs yocto-check-layer against the scarthgap LTS branch.
yocto-check-layer's test_patches_upstream_status flags any patch that doesn't carry an Upstream-Status: header. The two modules_install patches are generic and could plausibly land upstream (Pending); the IPS-disable patch is a downstream behavioural tweak that won't (Inappropriate).
yocto-check-layer's test_readme requires the README contain the word "maintainer". Point users at the GitHub issues/PRs as the canonical channel.
This reverts commit d1efbb3. Upstream poky scarthgap and walnascar still decorate test_patches_upstream_status with @unittest.expectedFailure, which means correctly-tagged patches turn the test into an "unexpected success" and fail the run. The decorator is finally removed in whinlatter; re-add Upstream-Status headers when CI moves off scarthgap LTS.
scarthgap's test_readme asserts that the README contains the strings "maintainer", "patch", and an email address. Add "patches" to the maintainer paragraph and a maintainer email to cover all three.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes meta-rtlwifi after a year of drift so it actually works against currently-shipping Yocto releases and is wired up with CI to catch the next round of bitrot.
Layer compatibility was last updated for scarthgap; this drops the EOL series (dunfell, gatesgarth, mickledore) and claims compat with kirkstone, scarthgap, styhead, walnascar, whinlatter and wrynose. LAYERVERSION and LAYERDEPENDS on core are added (both expected by yocto-check-layer), and BBFILE_PATTERN is anchored to
^${LAYERDIR}/so it can't accidentally match other layers.Two SUMMARY/DESCRIPTION copy-paste bugs are fixed: rtl8192eu.bb described itself as "RTL8192AU", and rtl8723du.bb described itself as "RTL88x2BU" (this was the recipe referenced in issue #25). The 8723du recipe also gains an explicit
DEPENDS = "virtual/kernel"and drops the?=on LIC_FILES_CHKSUM so downstream overrides can't accidentally hide a license mismatch.A GitHub Actions workflow runs on every push and PR:
All four parse jobs succeeded locally against the same branches, fetch succeeded for every recipe, and rtl8821cu was compile-tested end-to-end against scarthgap with linux-yocto 6.6.127 (module built, packaged, QA clean). Compile coverage for the other seven drivers is intentionally out of scope here and will be a follow-up.
README gets a CI badge, a list of CI-verified releases, and a usage snippet.
Closes #25 (the rtl8723du recipe metadata bug that made it look like rtl88x2bu). Does not address #26 (rtl8192eu compile failure on STM32MP1) — no reproducer in the issue and the recipe still parses/fetches; future compile-matrix CI will reveal whether it builds against current kernels.