filter ingestor array on controlled_vocabulary list#1292
Open
mikesndrs wants to merge 2 commits intoElixirTeSS:masterfrom
Open
filter ingestor array on controlled_vocabulary list#1292mikesndrs wants to merge 2 commits intoElixirTeSS:masterfrom
mikesndrs wants to merge 2 commits intoElixirTeSS:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the ingestor pipeline to optionally normalize certain array fields (e.g., target_audience, keywords) against a controlled vocabulary mapping, controlled via a new feature.controlled_vocabulary_vars setting.
Changes:
- Refactors auto-parsing logic into
handle_auto_parsingand reuses shared mapping-loading viaget_mapping. - Adds
handle_controlled_vocabularyand applies it to both event and material ingestion. - Adds unit tests validating controlled-vocabulary behavior when the feature flag is enabled/disabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/unit/ingestors/ingestor_test.rb | Adds coverage for controlled-vocabulary normalization behavior. |
| lib/ingestors/material_ingestion.rb | Routes material ingestion through the new helper methods. |
| lib/ingestors/event_ingestion.rb | Routes event ingestion through the new helper methods. |
| lib/ingestors/auto_parsing.rb | Introduces shared mapping loader + controlled vocabulary normalization helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist