MOM_interface changes for regional setups#316
MOM_interface changes for regional setups#316manishvenu wants to merge 6 commits intoESCOMP:mainfrom
Conversation
| MLE_USE_PBL_MLD: | ||
| description: | | ||
| "TODO" | ||
| "TODO |
There was a problem hiding this comment.
Hey Alper, I wasn't sure if this was just for the description, if it is, happy to remove it
There was a problem hiding this comment.
yes, i think it's just for the description.
|
@manishvenu Is this PR ready for testing? Any reason to keep it draft, or is it ready to be reviewed? |
mnlevy1981
left a comment
mnlevy1981
left a comment
There was a problem hiding this comment.
If the regular expressions in config_pes.xml get to be too much, we can punt on that... but I do think we want to update config_component.xml
| <valid_values>REGIONAL,GLOBAL</valid_values> | ||
| <default_value>GLOBAL</default_value> | ||
| <values> | ||
| <value compset="_MOM6%REGIONAL">REGIONAL</value> |
There was a problem hiding this comment.
If you change this to
-<value compset="_MOM6%REGIONAL">REGIONAL</value>
+<value compset="_MOM6%[^_]*REGIONAL">REGIONAL</value>Then you are not required to put %REGIONAL as the first compset modifier (MOM6%REGIONAL%MARBL-BIO would be equivalent to MOM6%MARBL-BIO%REGIONAL)
| </pes> | ||
| </mach> | ||
| <mach name="derecho"> | ||
| <pes pesize="any" compset="_DATM.+_SICE.*_MOM6%REGIONAL(?!.*%MARBL-BIO).+_SWAV"> |
There was a problem hiding this comment.
Same thing, I think you want MOM6%[^_]*REGIONAL here
There was a problem hiding this comment.
hmm, you might need additional logic to rule out MOM6%MARBL-BIO%REGIONAL. What a mess
| <rootpe_glc>0</rootpe_glc> | ||
| </rootpe> | ||
| </pes> | ||
| <pes pesize="any" compset="_DATM.+_SICE.*_MOM6%REGIONAL[^_]*MARBL-BIO.+_SWAV"> |
There was a problem hiding this comment.
this one is trickier, because you need an or statement to capture when MARBL-BIO precedes REGIONAL, but I would start with MOM6%[^_]*REGIONAL[^_]*MARBL-BIO. The right answer might be MOM6%([^_]*REGIONAL[^_]*MARBL-BIO|[^_]*MARBL-BIO[^_]*REGIONAL) but I'm not super confident in that
| <rootpe_glc>0</rootpe_glc> | ||
| </rootpe> | ||
| </pes> | ||
| <pes pesize="any" compset="_DATM.+_CICE.*_MOM6%REGIONAL(?!.*%MARBL-BIO).+_SWAV"> |
There was a problem hiding this comment.
same as one of the above comments
| <rootpe_glc>0</rootpe_glc> | ||
| </rootpe> | ||
| </pes> | ||
| <pes pesize="any" compset="_DATM.+_CICE.*_MOM6%REGIONAL[^_]*MARBL-BIO.+_SWAV"> |
There was a problem hiding this comment.
same as one of the above comments
3 participants
Details:
Changes to the configuration for regional setups. This includes new PE layouts, new compsets, and a new xml variable to turn on regional defaults, which currently only changes MOM_input. The bulk of the new changes are to MOM_input.