fix: correct Renovate preset path and migrate matchPackagePatterns#194
Merged
vredchenko merged 1 commit intomainfrom Apr 28, 2026
Merged
fix: correct Renovate preset path and migrate matchPackagePatterns#194vredchenko merged 1 commit intomainfrom
vredchenko merged 1 commit intomainfrom
Conversation
This repo hosts the shared renovate/default.json preset, and its own
renovate.json self-extends that preset using the wrong separator.
Renovate's syntax uses : for sub-preset names and // for nested file
paths, so the correct reference is
github>DiamondLightSource/smartem-devtools//renovate/default
The previous : form fails preset resolution ("Preset name not found
within published preset config"), so Renovate could not process this
repo and stopped opening PRs.
Worth fixing here especially because this is the canonical example
that other DLS repos copy from (smartem-decisions, smartem-frontend
and fandanGO-cryoem-dls have all picked up the same broken syntax;
matching PRs are open in those repos: smartem-decisions#281,
smartem-frontend#81, fandanGO-cryoem-dls#17).
Also migrates matchPackagePatterns to matchPackageNames with the
embedded /regex/ form to remove silent auto-migration churn on every
Renovate run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related Renovate config cleanups.
1. Self-extending preset uses wrong separator (blocking)
This repo hosts the shared `renovate/default.json` preset, and its own `renovate.json` self-extends that preset. Renovate's reference syntax uses `:` for sub-preset names within a single file and `//` for nested file paths, so the correct reference is:
```
github>DiamondLightSource/smartem-devtools//renovate/default
```
The previous `:` form fails preset resolution ("Preset name not found within published preset config"), so Renovate cannot process this repo at all.
This is worth fixing here especially because this is the canonical example other DLS repos copy from. The same broken syntax was picked up in:
2. matchPackagePatterns -> matchPackageNames (cosmetic)
`matchPackagePatterns` was deprecated and Renovate auto-migrates it to `matchPackageNames` with the embedded `/regex/` syntax on every run. Auto-migration is silent and harmless, but pinning the replacement in source removes the migration step. Exact-name matches now use plain strings, prefix patterns keep regex form.
The `playwright-skill` and `Python deps` rules already used the modern form and are unchanged.
Test plan