Conversation
akademy
added
accepted
Member
|
Sorry, just looking some more to this. Will look at it again on Monday. |
akademy
approved these changes
Apr 27, 2026
Member
akademy
left a comment
akademy
left a comment
There was a problem hiding this comment.
Yes! Still looks good! (I was getting complications switching to MUI 7 on our DataCats, all good now.)
Member
|
You might need #163 to fix CI. |
VictoriaBeilsten-Edmands
approved these changes
Apr 27, 2026
Collaborator
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
I've merged in #163
Collaborator
Author
|
Just merged in changes from main, but all should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MUI v7 (as a stepping stone to v9) has been out for a while, but v8 and v9 are not supported by JSON Forms, so I've upgraded to v7 and took care of some breaking changes.
I've also moved
material-iconsto be a base dependency, which if we use the tree-shaking feature by importing from default exports, has a minimal impact on bundle size (instead of importing all ofmaterial-icons, since on v7, the bundling issue that required packages to use barrel imports was fixed.