Feature/readme update

[szymon-krysztofiak-dev]

Configuration for Webpack 4.

[codecov]

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #85   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          45     45           
=====================================
  Hits           45     45

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 716a0d6...6095f61. Read the comment docs.

[codecov]

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #85   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          45     45           
=====================================
  Hits           45     45

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 716a0d6...6095f61. Read the comment docs.

[codecov]

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #85   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          45     45           
=====================================
  Hits           45     45

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776bd43...f8a2244. Read the comment docs.

[fatboypunk]

Thanks for your pull request, looks good to me, @sn3p any thoughts?

[sn3p]

@SzymonKrysztofiak thanks for the PR 💯 Will look into it today

[szymon-krysztofiak-dev]

No problem, btw. this is very good lib, and if You have any suggestions to this PR, i'll find time to look at this again :)

[sn3p]

Thanks for sharing your implementation. I really like the path aliases :)

We are in the process of moving from Brunch to Webpack in our apps. Our approach is slightly different, but I guess the result is the same (?). We are kinda new to Webpack so I'm not sure if we are on the right track.

I'm curious, would you prefer one implementation over the other?

assets/webpack.config.js

const glob = require("glob");

module.exports = {
  entry: {
    app: [].concat(
      glob.sync("./js/**/*.js"),
      glob.sync("../lib/app_web/cells/**/*.js"),
      glob.sync("../lib/app_web/views/**/*.js"),

      glob.sync("./css/app.css"),
      glob.sync("../lib/app_web/cells/**/*.css"),
      glob.sync("../lib/app_web/views/**/*.css")
    )
  }
}

assets/js/app.js

import { Builder as CellBuilder } from "@defacto/cell-js";

CellBuilder.reload();

lib/app_web/cells/avatar/index.js

import { Cell, Builder } from "@defacto/cell-js";

class AvatarCell extends Cell {
  initialize() {}
}

Builder.register(AvatarCell, "AvatarCell");

export default AvatarCell;

[sn3p]

We are kinda new to Webpack so I'm not sure if we are on the right track.

I'm saying this because we are experiencing some issues with our implementation of CSS Modules (see this post on StackOverflow).

Are you using CSS Modules by any chance?

[sn3p]

How did you install cell-js? I would expect this:

import { Cell, Builder } from "@defacto/cell-js";

Would you mind sharing your webpack entry config?

[szymon-krysztofiak-dev]

Thanks, I'll respond for couple hours :)

[szymon-krysztofiak-dev]

In assets i have src folder and app.js file which is the entry point of my webpack.config.js

  entry: {
    "./js/app.js": "./src/js/app.js"
  },

But now i see that i have a copy of builder.js and cell.js lib in vendor folder. I'll try import it from node modules.

[sn3p]

But now i see that i have a copy of builder.js and cell.js lib in vendor folder. I'll try import it from node modules.

That explains 😄
Let me know if importing the package works fo you. If so I'd say we use this in the examples so we can get this merged 🚀

[szymon-krysztofiak-dev]

Unfortunately, I don't work with CSS-Modules.

Maybe @TheLarkInn will be able to help, he is an expert from Webpack.

[sn3p]

Unfortunately, I don't work with CSS-Modules.

Maybe @TheLarkInn will be able to help, he is an expert from Webpack

Any help or advise is welcome 👍