Wire batch flags into scrape/search/screenshot/codegen#27
Open
paulius-krutkis-dcd wants to merge 1 commit into
Open
Wire batch flags into scrape/search/screenshot/codegen#27paulius-krutkis-dcd wants to merge 1 commit into
paulius-krutkis-dcd wants to merge 1 commit into
Conversation
Attach --input-file, --input-column and --concurrency to every scrape-style command and dispatch into the batch pipeline when --input-file is present. - createTargetAction detects batch mode, rejects --input-file combined with a positional input, and otherwise runs each input through the same body builder + SDK call with bounded concurrency. - Primary positional args are now optional so the input can come from the file instead; a genuinely missing input raises a CliUsageError. - Binary targets (screenshot) write one file per item and require -o <dir>; non-binary targets stream ndjson or write per-item JSON files. Integration tests cover flag exposure and the usage-error paths; the orchestrator is unit-tested end to end without network calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of 4 for the batch-input feature. Builds on
batch-output. Ties the previous layers into the actual commands.--input-file,--input-column,--concurrencyto every scrape-style command (scrape, search, screenshot, and all codegen targets).createTargetActiondetects batch mode, rejects--input-filecombined with a positional input, and otherwise runs each input through the same body builder + SDK call with bounded concurrency.CliUsageError.-o <dir>; non-binary targets stream ndjson by default or write per-item JSON files when-o <dir>is given.Integration tests cover flag exposure and the usage-error paths; the orchestrator is unit-tested end to end without network calls.
Stack: 1/4 batch-input-parsing → 2/4 batch-executor → 3/4 batch-output → 4/4 (this)