Skip to content

Port OTEP-4947 thread-context writer from polarsignals/custom-labels #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
szegedi wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Port OTEP-4947 thread-context writer from polarsignals/custom-labels #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67b647f
Port OTEP-4947 thread-context writer from custom-labels/js
szegedi May 27, 2026
9b207e6
Add test:docker harness for running tests on Linux from any host
szegedi May 27, 2026
f07c4ce
Address review feedback
szegedi Jun 10, 2026
64d4d68
Rename CtxWrap::Bytes to DebugBytes
szegedi Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"bindings/binding.cc",
"bindings/map-get.cc",
"bindings/allocation-profile.cc",
"bindings/allocation-profile-node.cc"
"bindings/allocation-profile-node.cc",
"bindings/otel-thread-ctx.cc"
],
"include_dirs": [
"bindings",
Expand All @@ -46,7 +47,8 @@
"bindings/translate-time-profile.cc",
"bindings/test/binding.cc",
"bindings/allocation-profile.cc",
"bindings/allocation-profile-node.cc"
"bindings/allocation-profile-node.cc",
"bindings/otel-thread-ctx.cc"
],
"include_dirs": [
"bindings",
Expand Down Expand Up @@ -81,6 +83,15 @@
["-Wno-deprecated-declarations"],
"cflags_cc!": ["-std=gnu++14", "-std=gnu++1y", "-std=gnu++20" ],
"cflags_cc": ["-std=gnu++2a"],
"conditions": [
# -mtls-dialect=gnu2 forces TLSDESC on x86_64 so the
# otel_thread_ctx_nodejs_v1 symbol is reachable per the
# OTEP-4947 spec. On arm64 TLSDESC is the only dynamic
# model, so no flag is needed there.
['target_arch == "x64"', {
"cflags": ["-mtls-dialect=gnu2"],
}],
],
}
],
["OS == 'mac'",
Expand Down
2 changes: 2 additions & 0 deletions bindings/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <v8.h>

#include "allocation-profile-node.hh"
#include "otel-thread-ctx.hh"
#include "profilers/heap.hh"
#include "profilers/wall.hh"
#include "translate-time-profile.hh"
Expand Down Expand Up @@ -53,5 +54,6 @@ NODE_MODULE_INIT(/* exports, module, context */) {
dd::TimeProfileNodeView::Init(exports);
dd::HeapProfiler::Init(exports);
dd::WallProfiler::Init(exports);
dd::OtelThreadCtx::Init(exports);
Nan::SetMethod(exports, "getNativeThreadId", GetNativeThreadId);
}
Loading
Loading