Speed-up unit tests#6
Merged
nunoplopes merged 3 commits intoCpp2Rust:masterfrom Apr 17, 2026
Merged
Conversation
Contributor
|
Isn't this missing the removal of Cargo.toml, or is that part of another PR? |
Contributor
Author
I removed it now, thanks! |
nunoplopes
reviewed
Apr 16, 2026
| import difflib, os, re, shutil, random | ||
| import tomli | ||
|
|
||
| def read_rust_version(): |
Contributor
There was a problem hiding this comment.
this change (turning into a method) is not useful; it makes the code slower for no benefit.
Contributor
Author
There was a problem hiding this comment.
Should I also make sharedTargetDir and cargoEnv free functions instead of methods?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-part of #3
First unit test compiles libcc2rs and rules in cargo-target, then all unit-tests use the precompiled libraries from cargo-target instead of building them each time.