Translate void casts#47
Merged
nunoplopes merged 8 commits intoCpp2Rust:masterfrom May 1, 2026
Merged
Conversation
nunoplopes
reviewed
Apr 30, 2026
|
|
||
| void Converter::ConvertVoidCastExpr(clang::ExplicitCastExpr *expr) { | ||
| PushExprKind push(*this, ExprKind::Void); | ||
| StrCat("let _ = "); |
Contributor
There was a problem hiding this comment.
I don't think that the let is needed. You can just evaluate the expression as a statement. No clone needed either.
Contributor
Author
There was a problem hiding this comment.
Done. I used let _ = expr.clone() to avoid moving expr, but simply writing expr; is enough
Contributor
Author
There was a problem hiding this comment.
Actually no, the move still ocurs if expr is not Copy, for example:
int *p;
(void) p;So a clone is needed for those types
Contributor
Author
There was a problem hiding this comment.
Fixed. I now add clone for non-Copy types
lucic71
added a commit
to lucic71/cpp2rust
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.