Remove unnecessary empty-string guard and move ReplaceAll out of header#40
Merged
nunoplopes merged 5 commits intomasterfrom Apr 29, 2026
Merged
Remove unnecessary empty-string guard and move ReplaceAll out of header#40nunoplopes merged 5 commits intomasterfrom
nunoplopes merged 5 commits intomasterfrom
Conversation
Agent-Logs-Url: https://github.com/Cpp2Rust/cpp2rust/sessions/e2a9ad06-b710-45c2-9ef9-b2ee3873b11c Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cpp2Rust/cpp2rust/sessions/e2a9ad06-b710-45c2-9ef9-b2ee3873b11c Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cpp2Rust/cpp2rust/sessions/0703124b-eddd-4240-bcdd-b114812b1b87 Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cpp2Rust/cpp2rust/sessions/5adfcfd4-fbee-476c-afc9-cb60f688cec2 Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cpp2Rust/cpp2rust/sessions/73fb334b-46a8-4ab4-96ed-332380c8dcdf Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
nunoplopes
April 28, 2026 20:50
View session
Copilot AI
added a commit
that referenced
this pull request
Apr 29, 2026
Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReplaceAllwas definedinlineinconverter_lib.hand contained an unnecessary early-return guard for an emptyfromargument.Changes
converter_lib.h: Replaceinlinedefinition with a plain declarationconverter_lib.cpp: AddReplaceAlldefinition; drop theif (from.empty()) return str;guard —str.find("", pos)never returnsnpos, so the loop body would never execute anyway, making the check redundant