Fix detection of va_list type#20
Merged
nunoplopes merged 4 commits intoCpp2Rust:masterfrom Apr 20, 2026
Merged
Conversation
Contributor
Author
|
Fixes the macOS errors in #12 |
Contributor
Author
|
In C++ mode, for va_list, on both macOS and Ubuntu, clang typedefs to In C mode, clang typedefs to That's why the va_arg tests broke after switching to C mode. |
Contributor
|
3 tests still failing |
Contributor
Author
It works now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS
va_listis typedef'ed tochar*, on Linux is typedefed to__va_list_tag[1]. Traverse the TypedefType/AdjustedType in order to check if a type is va_list instead of checking against the Linux specific__va_list_tag.