Skip to content

Harden clang tooling inputs against ASan use-after-poison by removing non-owning string views #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Harden clang tooling inputs against ASan use-after-poison by removing non-owning string views #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04e281f
Initial plan
Copilot Apr 19, 2026
192a6e7
Use owning strings for transpile inputs and flags
Copilot Apr 19, 2026
455f7b1
Revert incorrect string_view fix; add ASan allow_user_poisoning=0 wor…
Copilot Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cpp2rust/cpp2rust.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,17 @@

#include "cpp2rust_lib.h"

// LLVM's BumpPtrAllocator intentionally poisons freed slab memory via
// __asan_poison_memory_region. When ASan is enabled this can produce
// use-after-poison false positives inside clang/LLVM itself (e.g. during
// IdentifierTable initialisation). Opting out of user-poisoning suppresses
// those LLVM-internal false positives without affecting real UAF detection.
#if defined(__has_feature) && __has_feature(address_sanitizer)
extern "C" const char *__asan_default_options() {
return "allow_user_poisoning=0";
}
#endif

namespace fs = std::filesystem;

namespace {
Expand Down