fix: polish instance picker, fix modal focus rings, and hide remote storage info#985
Open
MaanilVerma wants to merge 4 commits into
Open
fix: polish instance picker, fix modal focus rings, and hide remote storage info#985MaanilVerma wants to merge 4 commits into
MaanilVerma wants to merge 4 commits into
Conversation
- BrandTakeoverLayout/BaseModal/BaseAlert/WhyTryCloudModal/MigrateConfirmTakeover: focus the role="dialog" container (tabindex="-1") instead of the first button, so opening no longer paints a focus-visible ring; keyboard focus stays trapped. - TrackModal/LoadSnapshotModal: prefer a real input/select, else fall back to the dialog container — never a button. - Drop now-unused button refs.
- InstancePickerView: wrap the left instance list in a TransitionGroup reusing ChooserView's tile motion (enter/leave fade + FLIP move) so filtering reflows smoothly. - StatusFactPanel: hide the "Location & storage" group for cloud/remote instances (no local footprint); keep the editable remote URL row, which lives under Instance details. - StatusFactPanel: show the URL edit pencil at rest (opacity 0.6) instead of hover-only. - ProgressModal: replace the clipped stack scrim with a centered blurred circle behind the wordmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish pass on the launcher's instance picker and per-instance About tab, plus a focus-trap fix shared by every modal/takeover. Opening any dialog no longer flashes a focus ring, the picker list now animates when filtered, and the About tab stops showing local-storage rows for cloud/remote connections.
Changes
What
BrandTakeoverLayout/BaseModal/BaseAlert/WhyTryCloudModal/MigrateConfirmTakeover: focus therole="dialog"container (tabindex="-1") on open instead of the first button, so opening via mouse/programmatic focus no longer paints a:focus-visiblering. Focus stays trapped for keyboard/AT users — they Tab from the container to reach controls.TrackModal/LoadSnapshotModal: on open, prefer a realinput/select(lets the user type immediately), otherwise fall back to the dialog container — never a button. This fixesLoadSnapshotModal's "Browse" button getting the ring in its empty state.InstancePickerView: wrap the left instance list in a<TransitionGroup name="picker-row">reusingChooserView'stilemotion (enter rise+fade 200ms, leave fade-out-of-flow 140ms, FLIP move 220ms iOS curve) so search/filter reflows smoothly. Added alockLeavingRowSizeFLIP hook and aprefers-reduced-motionfallback.StatusFactPanel: hide the "Location & storage" group whensourceCategory !== 'local'— cloud/remote connections have no local footprint (also covers the "no disk data" case, sincediskUsageisnullfor them).StatusFactPanel: show the remote-URL edit pencil at rest (opacity: 0.6) instead of hover-only; dropped the redundant row-hover reveal rule.ProgressModal: replace the clipped stack ellipse scrim with a centered blurred circle behind the wordmark/bar/text.Breaking
remote.url= "URL" label lands under Instance details, not Location & storage).Review Focus
StatusFactPanelgate: verify cloud/remote instances lose only the storage group and keep the editable URL row.ModalDialog,BaseSelect,BaseMenu,BaseActionSheet) were deliberately left unchanged — inputs don't exhibit the button-ring issue.Testing
UI/visual changes with no logic-path impact, so verification is manual + the existing typecheck/lint gauntlet; no new unit tests (they'd only re-assert unchanged store/IPC behavior).
pnpm typecheck(node/web/e2e/integration) — clean.pnpm lint— clean.