NW | 26-SDC-Mar | TzeMing Ho | Sprint 4 | Coursework/implement cowsay#446
Open
TzeMingHo wants to merge 5 commits into
Open
NW | 26-SDC-Mar | TzeMing Ho | Sprint 4 | Coursework/implement cowsay#446TzeMingHo wants to merge 5 commits into
TzeMingHo wants to merge 5 commits into
Conversation
TzeMingHo
added
📅 Sprint 4
illicitonion
added
Review in progress
illicitonion
force-pushed
the
coursework/implement-cowsay
branch
from
2b5b122 to
c9aa62b
Compare
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This looks good and works well - I left one comment about something to consider, but I'll mark the PR as complete :)
| @@ -0,0 +1 @@ | |||
| cowsay | |||
Member
There was a problem hiding this comment.
We generally put version number requirements into requirements.txt files, not just library names - take a read of https://www.reddit.com/r/learnpython/comments/16gu43v/why_add_package_versions_to_requirementstxt/ for some explanation of why.
illicitonion
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have made the animals say messages.